-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.arith: Use sage.rings.abc and move some module-level imports into methods #32600
Milestone
Comments
New commits:
|
Commit: |
Author: Matthias Koeppe |
comment:5
While it's not an issue here since it is not the main part of the algorithm, changes like this do incur a slight performance penalty: - if isinstance(z, (RealNumber, ComplexNumber)):
+ if isinstance(z.parent(), (RealField, ComplexField)): This is just for future reference. |
Reviewer: Travis Scrimshaw |
comment:6
Thanks! I agree with your analysis. |
Changed branch from u/mkoeppe/sage_arith__use_sage_rings_abc_and_move_some_module_level_imports_into_methods to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(cherry-picked from #32432)
Depends on #32566
CC: @tscrim
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
5e5843a
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32600
The text was updated successfully, but these errors were encountered: