-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove base ring attribute for the class ModularFormsRing #32349
Comments
Last 10 new commits:
|
Commit: |
comment:4
Only the last commit is pertinent (commit 1960959). |
Reviewer: Vincent Delecroix |
Changed branch from u/gh-DavidAyotte/remove_base_ring_attribute to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the implementation of the parent/element framework for the class
ModularFormsRing
in #31559, the__base_ring
attribute was not removed in the code. This ticket aims to remove this attribute and associated method so that the class use the inherited parent base ring method instead.This ticket is part of #31560.
Depends on #31559
CC: @videlec
Component: modular forms
Keywords: gsoc2021 modular forms ring base ring
Author: David Ayotte
Branch/Commit:
1960959
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/32349
The text was updated successfully, but these errors were encountered: