_sympy_ methods for Set_object_binary subclasses

[mkoeppe]

Formal unions, intersections, ...

Depends on #32013

CC: @tscrim @kcrisman @egourgoulhon

Component: interfaces

Author: Matthias Koeppe

Branch/Commit: 689986b

Reviewer: Travis Scrimshaw, Michael Jung

Issue created by migration from https://trac.sagemath.org/ticket/32015

[mkoeppe]

Branch: u/mkoeppe/_sympy__methods_for_set_object_binary_subclasses

[mkoeppe]

Commit: 3dd50e4

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Last 10 new commits:

6e5cac6	sage.interfaces.sympy_wrapper, Sets.ParentMethods._sympy_: New
3cac256	sage.interfaces.sympy_wrapper: Add doctests
eef604e	SageSet: Finish docstrings; handle symbolic _contains
2baae58	Sets.ParentMethods._sympy_: Call sympy_init
153b3e5	Merge #31938
c06c965	sage.interfaces.sympy_wrapper.SageSet: Add another doctest
f535127	Merge #31938
32cdd5c	Merge #31877
789dc05	Merge #31931
3dd50e4	sage.sets.set.Set_object: Add `_sympy_` methods to subclasses

[mkoeppe]

Changed dependencies from #32013, #31931, #31938 to #32013

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

200b1ef	Merge tag '9.4.beta4' into t/32013/initialize_a_set_from_a_convexset_base_instance
7f35aee	Merge #32013

[sagetrac-git]

Changed commit from 3dd50e4 to 7f35aee

[tscrim]

comment:6

I am not sure about caching the output of _sympy_? It creates a clone of the set and ties it to the Sage object. Can you give some reasoning for this?

[mkoeppe]

comment:7

If one makes one computation with the sympy version of a set, it's likely that another computation will be made -- so saving the result seemed a good idea.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:8

I would expect someone to store said Sympy version if they were going to use it again. Granted, I expect this to not be a problem either way. My instinct is to err on the side of not caching, but I don't have a strong opinion on this. So you either change it or not; once decided, you can set a positive review.

[mkoeppe]

comment:9

Thanks! I'm keeping it as is.

[vbraun]

comment:10

[docpdf] 
[docpdf] Overfull \hbox (22.51231p
[docpdf] ! Missing { inserted.
[docpdf] <to be read again> 
[docpdf]                    _
[docpdf] l.1488 ...n{}in class providing the operators \(__
[docpdf]                                                   add__\) and \(__sub__\).
[docpdf] ? 
[docpdf] [809
[docpdf] ! Emergency stop.
[docpdf] <to be read again> 
[docpdf]                    _
[docpdf] l.1488 ...n{}in class providing the operators \(__
[docpdf]                                                   add__\) and \(__sub__\).
[docpdf] !  ==> Fatal error occurred, no output PDF file produced!

[sagetrac-git]

Changed commit from 7f35aee to daeb91e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

daeb91e

src/sage/sets/set.py: Fix docstring markup

[vbraun]

comment:13

Tests fail

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2682469

src/sage/interfaces/sympy_wrapper.py: Use Family, not Set, in doctests to make sure that the SageSet wrapper is actually used

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

753babb

Set_object_enumerated._sympy_: Translate empty sets to EmptySet

[sagetrac-git]

Changed commit from 2682469 to 753babb

[tscrim]

comment:17

LGTM.

[mjungmath]

comment:18

File "src/sage/categories/sets_cat.py", line 1720, in sage.categories.sets_cat.Sets.ParentMethods._sympy_
Failed example:
    sF = F._sympy_(); sF
Expected:
    SageSet({1, 2})
Got:
    Set(1, 2)

and

File "src/sage/categories/sets_cat.py", line 1722, in sage.categories.sets_cat.Sets.ParentMethods._sympy_
Failed example:
    sF._sage_() is F
Exception raised:
    Traceback (most recent call last):
      File "/data/pell/lipnik/patchbot/local/lib/python3.9/site-packages/sage/doctest/forker.py", line 718, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/data/pell/lipnik/patchbot/local/lib/python3.9/site-packages/sage/doctest/forker.py", line 1137, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.categories.sets_cat.Sets.ParentMethods._sympy_[12]>", line 1, in <module>
        sF._sage_() is F
    AttributeError: 'Set' object has no attribute '_sage_'

[sagetrac-git]

Changed commit from 753babb to 451f5cf

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

451f5cf

Sets.ParentMethods: Update doctest

[tscrim]

comment:21

Thanks for catching that.

[mjungmath]

comment:22

sage -t --random-seed=0 src/sage/categories/sets_cat.py
    [478 tests, 0.52 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

[mjungmath]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Michael Jung

[mkoeppe]

comment:23

Thanks!

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

63c2cfe	ConvexSet_base._test_convex_set: Do not test _test_as_set_object here
55240bb	Merge #30473
fff2a79	src/sage/sets/set.py: Fix docstring markup
70a2e7d	Merge #32013
689986b	Merge tag '9.4.beta5' into t/32015/_sympy__methods_for_set_object_binary_subclasses

[sagetrac-git]

Changed commit from 451f5cf to 689986b

[vbraun]

Changed branch from u/mkoeppe/_sympy__methods_for_set_object_binary_subclasses to 689986b