Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifolds: Add _test_... methods that check invariants of subset relations #31682

Open
mkoeppe opened this issue Apr 17, 2021 · 0 comments
Open

manifolds: Add _test_... methods that check invariants of subset relations #31682

mkoeppe opened this issue Apr 17, 2021 · 0 comments
Labels
c: manifolds p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 17, 2021

Such as checking that self is a subset of every one of each supersets.

_top_subsets appears to be underspecified.
Code only adds to it but never removes anything, so it is not able to maintain the invariant of being the list of maximal proper subsets of self.

CC: @mjungmath @egourgoulhon @tscrim

Component: manifolds

Issue created by migration from https://trac.sagemath.org/ticket/31682
@mkoeppe mkoeppe added this to the sage-9.4 milestone Apr 17, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkoeppe