Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron.relative_interior_manifold, as_manifold_subset #31660

Open
mkoeppe opened this issue Apr 11, 2021 · 44 comments
Open

Polyhedron.relative_interior_manifold, as_manifold_subset #31660

mkoeppe opened this issue Apr 11, 2021 · 44 comments
Labels
c: manifolds p: major / 3 s: needs work t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 11, 2021

We extend the ManifoldSubsetPullback constructor to handle relatively open convex sets.

In this case, we

We add ConvexSet_base methods

  • as_manifold_subset.
  • relative_interior_manifold

Next step: Polyhedron.face_manifold_poset, top element of which is the polyhedron as a union of its relative interior and its facets. Using #31732, the intersection of the relative interior and each facet is declared empty.

Depends on #31688
Depends on #31963
Depends on #31993

CC: @mjungmath @kliem @yuan-zhou @jplab @tscrim @egourgoulhon

Component: manifolds

Work Issues: Refactor through #31688, #31916, #31963, #31993

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/polyhedron_relative_interior_manifold @ 1f4bd68

Issue created by migration from https://trac.sagemath.org/ticket/31660
@mkoeppe mkoeppe added this to the sage-9.3 milestone Apr 11, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 11, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2021

Branch: u/mkoeppe/polyhedron_relative_interior_manifold

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2021

Last 10 new commits:

8414039Polyhedron_base.affine_hull_projection: Document a weaker guarantee of parametric_form
dba2763Polyhedron_base.affine_hull_projection: Replace 'affine_map' by 'projection_map', 'parametric_form'/'coordinate_images' by 'section_map'
d49c313Polyhedron_base.affine_hull_projection: section map for non-orthogonal case
d77181bAdd doctest
6f30843Polyhedron_base.affine_hull_manifold: New
0538280Polyhedron_base.affine_hull_manifold: Finish
f2bdbf2Add example
eb88cfealso plot the polyhedron
10136e9Put '# not tested' in the right place
cead8cePolyhedron_base.relative_interior_manifold: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2021

Commit: cead8ce

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2021

Changed dependencies from #31659 to #31659, #31674

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2021

Changed commit from cead8ce to 1c2b1bb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d815b63{DifferentiableSubmanifold,PseudoRiemannianSubmanifold}.open_subset: New
3fc1922Merge #31674
006fd02{Topological,Differentiable,PseudoRiemannianSubmanifold}._repr_: Print subsets as subsets
ed1a2eaUpdate doctest output: Riemannian
aac8835{Topological,Differentiable,PseudoRiemannianSubmanifold}._repr_: Print subsets as subsets
004c23aAdd/update examples
ef1614aRefactor Manifold.open_subset methods through new method _init_open_subset
b2ccbbaMerge #31674
3fdb300Polyhedron_base.affine_hull_manifold: Small edit to the doctest
1c2b1bbPolyhedron_base.relative_interior_manifold: Use open_subset method

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 19, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

643392cUse new format of affine hull data
57dce72Polyhedron.affine_hull_manifold: Update doctests
a4d3d5cMerge #31659
265b0e2TopologicalManifold._init_open_subset: Add docstring
a93f7edTopologicalSubmanifold._init_open_subset: Add docstring
58b43f7DifferentiableManifold._init_open_subset: Add docstring
dee6cefMerge #31674
730f5e6Update doctest
a47ea80Update doctest
7a6a10cMerge #31659

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 19, 2021

Changed commit from 1c2b1bb to 7a6a10c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 20, 2021

Changed commit from 7a6a10c to 9734f98

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

9734f98Polyhedron_base.relative_interior_manifold: Substitute the values of the foliation parameters

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Changed commit from 9734f98 to 9e8eb27

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b17aa8cadd another doctest
eee1aadfix section map
915389dMerge #27366
9e8eb27Merge #31659

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 16, 2021

Changed dependencies from #31659, #31674 to #31659, #31674, #31644

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ee4efc9ManifoldSubset._{union,intersection}_subset: Do cache the result here; add examples
e7f7a7dMerge #31764
9259a2cMerge #31798
ac53984src/sage/manifolds/subsets/__init__.py: New
f88e410Merge #31644
87a2beaPolyhedron_base.affine_hull_manifold: In the full-dimensional case, do not create a submanifold
8af2c71Polyhedron_base._affine_hull_name_latex_name: Add docstring
05d228cMerge #31659
d79a8cbPolyhedron_base.relative_interior_manifold: Handle the full-dimensional case
200096bPolyhedron_base.as_manifold_subset: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2021

Changed commit from 9e8eb27 to 200096b

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Polyhedron.relative_interior_manifold Polyhedron.relative_interior_manifold, as_manifold_subset May 16, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2021

Changed commit from 200096b to 54f736b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8c6759aMake docstrings raw
8110203Merge #31659
54f736bMake docstrings raw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 6, 2021

Work Issues: Refactor through #31688, #31916

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 11, 2021

comment:20

With #31916, instead of introducing relative_interior_manifold(...), one would write relative_interior().as_manifold_subset(...)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 12, 2021

comment:21

Likewise with #31963 for affine_hull()

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2021

Changed dependencies from #31659, #31674, #31644 to #31688, #31916

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2021

Changed dependencies from #31688, #31916 to #31688, #31916, #31963

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2021

Changed dependencies from #31688, #31916, #31963 to #31688, #31963

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

768afc7Polyhedron_base.relative_interior_manifold: New
39d5679Update doctest output: Riemannian
88adca6Polyhedron_base.affine_hull_manifold: Small edit to the doctest
94dfbe4Polyhedron_base.relative_interior_manifold: Use open_subset method
cb030e6Update doctest
bb60d84Polyhedron_base.relative_interior_manifold: Substitute the values of the foliation parameters
80f9213Polyhedron_base.relative_interior_manifold: Handle the full-dimensional case
b103d9cPolyhedron_base.as_manifold_subset: New
02fba3cMake docstrings raw
3fd8f86Polyhedron_base.as_manifold_subset, relative_interior_manifold: Add argument ambient_chart

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Changed commit from 52802f8 to 3fd8f86

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

a9bc5bcPolyhedron_base.relative_interior_manifold: Update doctest output

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Changed commit from 3fd8f86 to a9bc5bc

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2021

Changed work issues from Refactor through #31688, #31916 to Refactor through #31688, #31916, #31963, #31993

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2021

Changed dependencies from #31688, #31963 to #31688, #31963, #31993

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f956fd3AffineHullProjectionData: Move from Polyhedron_base to sage.geometry.convex_set, rename field 'polyhedron' to 'image'
2a96f18sage.geometry: Import cached_method from a more specific module
0226965WIP ConvexSet_base.affine_hull_projection
23b08cdRelativeInterior.an_affine_basis: New; relax _test_affine_basis to accept closure points
0e2965fPolyhedron.affine_hull_projection: Refactor as ConvexSet_base.affine_hull_projection and Polyhedron._affine_hull_projection
837b7f5RelativeInterior.{dilation,linear_transformation,translation}: New
579303cConvexSet_base.dilation: Add default implementation, test
535e412ConvexSet_base.linear_transformation, translation: Add tests
e389f0aMerge #31993
0ddf3a8ManifoldSubsetPullback: WIP relatively open

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2021

Changed commit from a9bc5bc to 0ddf3a8

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

9b183e2Polyhedron_base.affine_hull_manifold: Small edit to the doctest
2aa7080Polyhedron_base.relative_interior_manifold: Use open_subset method
d292893Update doctest
a01c24bPolyhedron_base.relative_interior_manifold: Substitute the values of the foliation parameters
a502039Polyhedron_base.relative_interior_manifold: Handle the full-dimensional case
79ce6daPolyhedron_base.as_manifold_subset: New
2a023e0Make docstrings raw
feebc50Polyhedron_base.as_manifold_subset, relative_interior_manifold: Add argument ambient_chart
d03c7d5Polyhedron_base.relative_interior_manifold: Update doctest output
1f4bd68ManifoldSubsetPullback: WIP relatively open

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Changed commit from 0ddf3a8 to 1f4bd68

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 s: needs work t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkoeppe