-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cysignals to 1.10.3 #31474
Comments
Commit: |
Branch: u/embray/ticket-31474 |
Work Issues: release cysignals 1.10.3 final and update spkg version, checksums |
New commits:
|
Author: Erik Bray |
comment:2
Building Sage against this is currently failing, likely due to sagemath/cysignals#134 |
comment:3
Replying to @embray:
Yes, this is how I found out about it in the first place. |
comment:4
After patching with sagemath/cysignals#134 all tests pass on my side. |
comment:5
Replying to @kliem:
I'm testing it now too, but thanks for confirming! I'll make a release candidate after. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed reviewer from https://github.com/kliem/sage/pull/40 to https://github.com/kliem/sage/pull/40/checks |
comment:9
Testing this on top of #31245. |
comment:10
Sage builds for me with this and all the tests pass except for the orthogonal one fixed at #26912. |
comment:12
This looks good to me modulo the actual release. |
Changed reviewer from https://github.com/kliem/sage/pull/40/checks to Jonathan Kliem |
comment:13
Ok, I'll make the final release then. It will be unchanged from the release candidate other than some CI fixes I made (which don't change the code). |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Ok then, this should be good to go. |
Changed work issues from release cysignals 1.10.3 final and update spkg version, checksums to none |
comment:17
Thank you for this release. |
Changed branch from u/embray/ticket-31474 to |
Cysignals 1.10.3 includes a fix for #30945 and other minor bug fixes.
Before setting this ticket to positive review we need to make a final release of 1.10.3, but here is a ticket adding a beta release for testing.
CC: @fchapoton @kiwifb @dimpase @mkoeppe @kliem @collares
Component: packages: standard
Keywords: cysignals
Author: Erik Bray
Branch/Commit:
81cab2b
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/31474
The text was updated successfully, but these errors were encountered: