Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put equations in stable position for backend cdd #31253

Closed
kliem opened this issue Jan 16, 2021 · 6 comments
Closed

Put equations in stable position for backend cdd #31253

kliem opened this issue Jan 16, 2021 · 6 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jan 16, 2021

Currently, equations positions in Hrepresentation of backend cdd depends on the input:

sage: P = polytopes.permutahedron(2, backend='cdd')                                                                                                                                 
sage: P.Hrepresentation()                                                                                                                                                           
(An equation (1, 1) x - 3 == 0,
 An inequality (0, 1) x - 1 >= 0,
 An inequality (1, 0) x - 1 >= 0)
sage: Q = Polyhedron(P.vertices(), backend='cdd')                                                                                                                                   
sage: Q.Hrepresentation()                                                                                                                                                           
(An inequality (-1, 0) x + 2 >= 0,
 An inequality (1, 0) x - 1 >= 0,
 An equation (1, 1) x - 3 == 0)

This leads to the following failure:

sage: [x.ambient_Hrepresentation() for x in P.facets()]                                                                                                                             
[(An inequality (1, 0) x - 1 >= 0, An inequality (0, 1) x - 1 >= 0),
 (An inequality (1, 0) x - 1 >= 0, An equation (1, 1) x - 3 == 0)]

We fix this by putting equations always in the same position.

CC: @jplab @LaisRast @mkoeppe

Component: geometry

Keywords: cdd, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 1c6c90a

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31253

@kliem kliem added this to the sage-9.3 milestone Jan 16, 2021
@kliem
Copy link
Contributor Author

kliem commented Jan 16, 2021

Commit: 1c6c90a

@kliem
Copy link
Contributor Author

kliem commented Jan 16, 2021

New commits:

1c6c90astable position for equations for backend cdd

@kliem
Copy link
Contributor Author

kliem commented Jan 16, 2021

Branch: public/31253

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 20, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 20, 2021

comment:2

LGTM.

@vbraun
Copy link
Member

vbraun commented Mar 22, 2021

Changed branch from public/31253 to 1c6c90a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants