Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'sage_setup: distribution' headers from sage-... to sagemath-... #31031

Closed
mkoeppe opened this issue Dec 9, 2020 · 15 comments
Closed

Change 'sage_setup: distribution' headers from sage-... to sagemath-... #31031

mkoeppe opened this issue Dec 9, 2020 · 15 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 9, 2020

(and change setup.py accordingly)

to reflect the naming scheme selected in #30912

CC: @dimpase @jhpalmieri @kliem

Component: build

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: 9dcd479

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31031
@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 9, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

comment:1

Best done together with #30151, which touches the same part of setup.py

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:2

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 15, 2021

Dependencies: #31377, #30913

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2021

Branch: u/mkoeppe/change__sage_setup__distribution__headers_from_sage_____to_sagemath____

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2021

Commit: f74f3c2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2021

New commits:

f74f3c2Change sage_setup: distribution headers from sage-... to sagemath-...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2021

Changed dependencies from #31377, #30913 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@tscrim
Copy link
Collaborator

tscrim commented Aug 15, 2021

comment:7

merge conflict.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2021

Changed commit from f74f3c2 to 9dcd479

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9dcd479Change sage_setup: distribution headers from sage-... to sagemath-...

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2021

comment:10

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 16, 2021

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 29, 2021

Changed branch from u/mkoeppe/change__sage_setup__distribution__headers_from_sage_____to_sagemath____ to 9dcd479

@vbraun vbraun closed this as completed in 88f4def Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe