-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system python for generation of conway_polynomials and elliptic_curves #30934
Comments
comment:2
These packages declare
|
comment:3
Thanks for the feedback. So what is the correct choice if the user does have a suitable system python? |
comment:4
When there is a suitable system python3, then Sage creates a venv over it, so |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
This change should not be done for one package but uniformly for all packages - in #30731. |
Dependencies: #30731 |
comment:9
Ok, then close this ticket here, although I don't really see why #30731 could't build upon this ticket. |
comment:10
Because this ticket on its own makes the codebase less uniform. |
Reviewer: Tobias Diez |
Changed author from Tobias Diez to none |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Changed commit from |
Changed branch from public/build/sharedSystemPython to none |
Instead of sage's python, the installation of conway_polynomials and elliptic_curves now uses the system python. This enables one to call
make conway_polynomials
without a prior compilation of python (which is helpful for #30371). Since the installation of these packages uses python only to convert files into the right format, using the system python should be fine.Depends on #30731
CC: @mkoeppe
Component: build
Reviewer: Tobias Diez
Issue created by migration from https://trac.sagemath.org/ticket/30934
The text was updated successfully, but these errors were encountered: