Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./configure --with-sage-venv=none #30896

Open
mkoeppe opened this issue Nov 11, 2020 · 22 comments
Open

./configure --with-sage-venv=none #30896

mkoeppe opened this issue Nov 11, 2020 · 22 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 11, 2020

(split out from #29013)

As of #32442, ./configure --with-sage-venv=no just means: Keep SAGE_VENV the same as SAGE_LOCAL.

In this ticket we add support for a new option, perhaps ./configure --with-sage-venv=none, which would suppress making any Python venv and suppress building any Python packages.
(Using the mechanism of disablable installation trees from #31356, #32759.)

In this configuration, sage_conf cannot be built as a wheel, so we only build an sdist (using sage-bootstrap-python!) and store that in $SAGE_LOCAL/var/lib/sage/wheels.

Also, the default target all-start makes no sense, and also the docbuild cannot be done. Instead, the default would be to build only the target all-sage (which would be modified to remove the unnecessary special case sagelib).

This is for users who prefer to install Python packages into their own virtual environments using standard Python tools.

Depends on #31362

CC: @dimpase @jhpalmieri @orlitzky @tobiasdiez

Component: build

Keywords: sd111

Work Issues: Rework as "--with-sage-venv=none" (implied by "--without-python"), rebase on #31362

Branch/Commit: u/mkoeppe/__configure___without_python @ 932ebd8

Issue created by migration from https://trac.sagemath.org/ticket/30896

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 11, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

comment:1

To disable building Python packages, the make targets would be replaced by dummy targets in the same way as it is done for packages found by spkg-configure.

In addition, this could go through #30383 ("configure --disable-SPKG" for standard packages) so that configure already shows that the build is disabled for Python packages.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Last 10 new commits:

f9ac70eAdd install-requires.txt for setuptools, pip
f6a2c56Merge tag '9.3.beta1' into t/30719/add_build_pkgs_spkg_install_requires_txt_for_all_python_packages
e61929dbuild/pkgs/sphinx/install-requires.txt: Update from gentoo
8fe0e35build/pkgs/python_openid: Unused, remove
ba1d913build/pkgs/itsdangerous: Unused, remove
bb6c4aebuild/pkgs/tox/install-requires.txt: New
d507501build/pkgs/networkx/install-requires.txt: Update from gentoo
c3a9352build/pkgs/pathpy/install-requires.txt: Package removed in #30611, remove
ebd4610build/pkgs/pynac/install-requires.txt: New
e25b833Merge branch 't/30719/add_build_pkgs_spkg_install_requires_txt_for_all_python_packages' into t/30896/__configure___without_python

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Commit: e25b833

@mkoeppe mkoeppe changed the title ./configure --without-python ./configure --without-sage-venv Nov 20, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Work Issues: Rework as "--without-sage-venv" (implied by "--without-python")

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:8

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fa13bfabuild/pkgs/python3/spkg-configure.m4: Accept --with-python=no
17869afm4/sage_spkg_collect.m4: If configured --without-python, mark all Python packages as not required

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2020

Changed commit from e25b833 to 17869af

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 24, 2021

Changed dependencies from #30719 to #31263

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2021

Changed commit from 17869af to 932ebd8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fec4b06fix sage -b after 30622
dff846cgo through make/build/install
8aff784build/pkgs/python3/spkg-configure.m4: Accept --with-python=no
932ebd8m4/sage_spkg_collect.m4: If configured --without-python, mark all Python packages as not required

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2021

Changed dependencies from #31263 to #31362

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 9, 2021

Changed work issues from Rework as "--without-sage-venv" (implied by "--without-python") to Rework as "--without-sage-venv" (implied by "--without-python"), rebase on #31362

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:15

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 25, 2021

Changed work issues from Rework as "--without-sage-venv" (implied by "--without-python"), rebase on #31362 to Rework as "--with-sage-venv=none" (implied by "--without-python"), rebase on #31362

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe removed this from the sage-9.5 milestone Sep 25, 2021
@mkoeppe mkoeppe changed the title ./configure --without-sage-venv ./configure --with-sage-venv=none Sep 25, 2021
@mkoeppe

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant