Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers' guide: Update "Packaging Third-Party Code" regarding upstream_url #30895

Closed
mkoeppe opened this issue Nov 11, 2020 · 13 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 11, 2020

... and other features of sage --package.

https://doc.sagemath.org/html/en/developer/packaging.html

Sources:

CC: @seblabbe @tobiasdiez @jhpalmieri @dimpase @paulmasson

Component: documentation

Author: Matthias Koeppe

Branch/Commit: 86e048f

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/30895

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 11, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

New commits:

8d07bb5src/doc/en/developer/packaging.rst: Mention upstream_url

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

Commit: 8d07bb5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Nov 21, 2020

comment:4

this is a bit off-topic:

Is there away to minimize checking of mirrors for tarballs that aren't there; if one adds an upstream_url, and starts installing this package, then it takes long time for Sage to discover that the tarball is not on mirrors, before using upstream_url.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2020

comment:5

Replying to @dimpase:

Is there away to minimize checking of mirrors for tarballs that aren't there; if one adds an upstream_url, and starts installing this package, then it takes long time for Sage to discover that the tarball is not on mirrors, before using upstream_url.

You can edit the file upstream/mirror_list.

@dimpase
Copy link
Member

dimpase commented Nov 22, 2020

comment:6

Can you add after

+--enable-download-from-upstream-url``.  Then Sage will fall back to
+downloading package tarballs from the ``upstream_url``.  It is then no
+longer necessary to manually download upstream tarballs.

something like

One can manually trim `upstream/mirror_list` to fewer mirrors so that the fallback
happens quicker.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

86e048fsrc/doc/en/developer/packaging.rst: Trimming mirror list

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2020

Changed commit from 8d07bb5 to 86e048f

@seblabbe
Copy link
Contributor

comment:8

bot is green for the doc changes.

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2020

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants