Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up "sage -p" #30657

Closed
mkoeppe opened this issue Sep 24, 2020 · 14 comments
Closed

Fix up "sage -p" #30657

mkoeppe opened this issue Sep 24, 2020 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 24, 2020

$ ./sage -p sagetex
Found local metadata for sagetex-3.5
Using cached file /Users/mkoeppe/s/sage/sage-rebasing/upstream/sagetex-3.5.tar.gz
mkdir: : No such file or directory
************************************************************************
Error creating directory 
************************************************************************

Depends on #29500

CC: @jhpalmieri @orlitzky

Component: build

Author: Matthias Koeppe

Branch/Commit: 8ee7ee2

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/30657

@mkoeppe mkoeppe added this to the sage-9.2 milestone Sep 24, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 24, 2020

Branch: u/mkoeppe/fix_up__sage__p_

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 24, 2020

Dependencies: #29500

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 24, 2020

comment:2

Branch is on top of #29500 because it touches the same code


Last 10 new commits:

0a64674build/pkgs/gambit/spkg-install.in: Install via bdist_wheel
ca58693build/pkgs/pillow/spkg-install.in: Install via bdist_wheel
5a747c4build/bin/sage-pip-{install,uninstall}: Remove pip2 support
9ee2110build/bin/sage-dist-helpers: Also use $sudo for storing the wheel file
d7aac84src/doc/en/developer/packaging.rst: Update sdh_... documentation
9b7c7a0build/bin/sage-pip-{install,uninstall}: Fix typo in comment
4135e8bbuild/bin/sage-pip-install: Remove an outdated comment
f2e7075Merge tag '9.2.beta13' into t/29500/install_all_python_packages_via_pip_wheel__create_pep_503_simple_repository_for_wheels
bd0fd2fMerge branch 't/29500/install_all_python_packages_via_pip_wheel__create_pep_503_simple_repository_for_wheels' into t/30657/fix_up__sage__p_
2e20f23build/bin/sage-spkg: Move SAGE_SPKG_{INST,SCRIPTS,WHEELS} setting here from build/bin/install, make them relative to SAGE_INST_LOCAL

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 24, 2020

Commit: 2e20f23

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 24, 2020

Author: Matthias Koeppe

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

comment:5

Looks OK I guess. The build/bin/sage-spkg script obviously needs these variables set, so it makes sense to move them "up" out of build/make/install where they are not used directly.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 25, 2020

comment:6

Thanks.

@vbraun
Copy link
Member

vbraun commented Oct 1, 2020

comment:7

Fails while building sage_conf-none for me... do incremental builds work?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

be2417cMerge tag '9.2.beta14' into t/30657/fix_up__sage__p_
8ee7ee2build/make/install: Set SAGE_SPKG_WHEELS also here so that script packages still work

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2020

Changed commit from 2e20f23 to 8ee7ee2

@orlitzky
Copy link
Contributor

orlitzky commented Oct 2, 2020

comment:10

The new commit is reverted on the #29386 branch, but looks good for now.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2020

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 5, 2020

Changed branch from u/mkoeppe/fix_up__sage__p_ to 8ee7ee2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants