Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R on macOS xcode 12 #30631

Closed
dimpase opened this issue Sep 22, 2020 · 11 comments
Closed

fix R on macOS xcode 12 #30631

dimpase opened this issue Sep 22, 2020 · 11 comments

Comments

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

configure fails to find bzlib, as the test function misses #includes
This is fixed upstream in the trunk (in Sept. 2020).

Upstream: Fixed upstream, but not in a stable release.

CC: @mkoeppe @jhpalmieri @slel

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: 376af90

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30631

@dimpase dimpase added this to the sage-9.2 milestone Sep 22, 2020
@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

Commit: 376af90

@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

Branch: u/dimpase/build/homebrewbzip

@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

New commits:

376af90backport configure fix from trunk, add bzip2 paths

@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

Author: Dima Pasechnik

@jhpalmieri
Copy link
Member

comment:3

This builds for me with Xcode 12. For what it's worth, the changes to .homebrew-build-env didn't have any effect for me since I don't have bzip2 installed via homebrew. Just using the system version seems to work fine.

@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

comment:4

OK, so then these changes to .homebrew-build-env are not needed in fact. I added them as I tried to get R to recognise bzip2, so I thought it might be a problem here.

@dimpase
Copy link
Member Author

dimpase commented Sep 22, 2020

comment:5

On the other hand there is no harm in the modification of .homebrew-build-env - it merely make sure that if Homebrew's bzip2 is installed then it gets used.

@jhpalmieri
Copy link
Member

comment:6

Sounds good.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@slel
Copy link
Member

slel commented Sep 24, 2020

comment:7

Marking as critical since it is needed for Xcode 12 support.

@vbraun
Copy link
Member

vbraun commented Sep 30, 2020

Changed branch from u/dimpase/build/homebrewbzip to 376af90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants