Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade various Python packages for Sage 9.3 #30611

Closed
mkoeppe opened this issue Sep 19, 2020 · 38 comments
Closed

Upgrade various Python packages for Sage 9.3 #30611

mkoeppe opened this issue Sep 19, 2020 · 38 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 19, 2020

On separate tickets:

CC: @kiwifb @slel

Component: packages: standard

Keywords: upgrade

Author: Matthias Koeppe

Branch/Commit: 13af6c6

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/30611

@mkoeppe mkoeppe added this to the sage-9.2 milestone Sep 19, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade numpy to 1.19.2 Upgrade various Python packages Nov 11, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade various Python packages Upgrade various Python packages for Sage 9.3 Nov 11, 2020
@kiwifb
Copy link
Member

kiwifb commented Nov 11, 2020

comment:4

sphinx and friends?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

Branch: u/mkoeppe/upgrade_numpy_to_1_19_2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

Last 10 new commits:

a368bb7build/pkgs/fpylll: Update to 0.5.2dev
be49932build/pkgs/kiwisolver: Update to 1.3.1
2b45418build/pkgs/markupsafe: Update to 1.1.1
25e7fb2build/pkgs/matplotlib: Update to 3.3.2
4bfae6ebuild/pkgs/packaging: Update to 20.4
1b3c2f0build/pkgs/pathpy: No longer required by pickleshare, remove
2e2e98bbuild/pkgs/pyparsing: Update to 2.4.7
f37753fbuild/pkgs/python_igraph: Update to 0.8.3
6c159bcbuild/pkgs/pytz: Update to 2020.4
514acf4build/pkgs/rpy2: Update to 3.3.6

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

Commit: 514acf4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

comment:7

Replying to @kiwifb:

sphinx and friends?

Separate ticket please

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b5fe879build/pkgs/markupsafe: Update to 1.1.1
e906edebuild/pkgs/matplotlib: Update to 3.3.2
d365707build/pkgs/packaging: Update to 20.4
248c84abuild/pkgs/pathpy: No longer required by pickleshare, remove
be5bdf2build/pkgs/pyparsing: Update to 2.4.7
51a45c0build/pkgs/python_igraph: Update to 0.8.3
014d4a6build/pkgs/pytz: Update to 2020.4
e1772fdbuild/pkgs/rpy2: Update to 3.3.6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Changed commit from 514acf4 to e1772fd

@mkoeppe

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented Nov 12, 2020

comment:10

Is there already a separate ticket for rpy2 somewhere? I seem to remember there was an issue (apart from py27 compatibility which we don't care about anymore).

python_igraph, can this be done without also upgrading igraph? I am expecting (gut feelings) issues.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Changed commit from e1772fd to 6314ba9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6314ba9build/pkgs/scipy/patches/extern_decls.patch: Remove

@kiwifb
Copy link
Member

kiwifb commented Nov 12, 2020

comment:12

Replying to @kiwifb:

Is there already a separate ticket for rpy2 somewhere? I seem to remember there was an issue (apart from py27 compatibility which we don't care about anymore).

Looks like I was thinking of 3.3.5 at #29441 but it is all fixed. I had an issue with it in Gentoo especially during testing that has been solved upstream in 3.3.6. So it is all good.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

comment:13

Replying to @kiwifb:

python_igraph, can this be done without also upgrading igraph? I am expecting (gut feelings) issues.

No idea; I'll push it to a separate ticket.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Changed commit from 6314ba9 to 7cd96b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

88b8427build/pkgs/pytz: Update to 2020.4
df7972cbuild/pkgs/rpy2: Update to 3.3.6
7cd96b2build/pkgs/scipy/patches/extern_decls.patch: Remove

@kiwifb
Copy link
Member

kiwifb commented Nov 12, 2020

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Nov 12, 2020

comment:17

I am quite happy with the ticket as it is. With a few exceptions (rpy2, certifi) we are at those levels in Gentoo and I don't expect issues.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 12, 2020

comment:18

Thanks!

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Nov 12, 2020

Changed keywords from none to upgrade

@slel
Copy link
Member

slel commented Nov 12, 2020

comment:19

Thanks for the upgrades!

Just to verbalise the removal of pathpy (our name for path.py).

The commit message for the removal commit says it all:

build/pkgs/pathpy: No longer required by pickleshare, remove

Indeed: ipython/pickleshare@2141463

Side note: on PyPI, path.py (which used to provide os.path
before the standard library included pathlib), is now path,
and there's a different unrelated pathpy for "analysis and
visualisation of time series data on complex networks with
higher- and multi-order graphical models".

Bye path.py. Sorry everyone for the noise.

@vbraun
Copy link
Member

vbraun commented Nov 17, 2020

comment:20

Can't find a networkx file with the right checksum, url is wrong

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

comment:21

It is indeed

upstream_url=https://github.com/networkx/networkx/archive/networkx-2.4.zip

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

comment:22

It looks like that is the only source not from pypi in the lot. Fixing.

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

Changed commit from 7cd96b2 to 84d778c

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

New commits:

84d778cFixing upstream url for networkx

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

comment:24

Back to positive review.

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

comment:25

Forgot to change stuff has I have gone from zip to tar.gz.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

13af6c6fix tarball name

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

Changed commit from 84d778c to 13af6c6

@kiwifb
Copy link
Member

kiwifb commented Nov 17, 2020

comment:27

Surprisingly, the checksum did not change.

@vbraun
Copy link
Member

vbraun commented Nov 22, 2020

Changed branch from u/fbissey/upgrade_numpy_to_1_19_2 to 13af6c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants