fix scipy for XCode 12

[dimpase]

Upstream: Fixed upstream, in a later stable release.

CC: @mkoeppe @jhpalmieri

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: 711fe05

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30604

[dimpase]

comment:1

upstream already have some of these fixes in master, but not all.

---

New commits:

711fe05

missing extern decls and #include statements for scipy on xcode12

[dimpase]

Branch: u/dimpase/packages/scipy/xcode12fix

[dimpase]

Commit: 711fe05

[dimpase]

comment:2

PR for the upstream master branch: scipy/scipy#12864

[jhpalmieri]

comment:3

The changes look sensible, I don't imagine them causing breakage on other platforms, and scipy now builds for me with Xcode 12.

[jhpalmieri]

Reviewer: John Palmieri

[dimpase]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

[dimpase]

comment:5

our PR is accepted upstream.

Do you know if Sage's scipy passed its tests on macOS before ?
It does not in this configuration.

[jhpalmieri]

comment:6

It seems that when I checked a year ago, it did pass its test suite.

[jhpalmieri]

comment:7

Actually, sorry, I misunderstood. I don't know if I've ever run scipy's tests: I typically only run tests using the spkg-check files in Sage (via SAGE_CHECK=yes), and scipy doesn't have one of those. So I didn't run its tests a year ago.

[dimpase]

comment:8

One can fire up Python and do

>>> import scipy
>>> scipy.test()

for a relatively short testsuite.
(It requires pytest installed).

[jhpalmieri]

comment:9

I don't have any machine with Xcode 11 to test with, unfortunately.

[zlscherr]

comment:10

I also don't have Xcode 11 any more, but my systemwide scipy on Mac and ubuntu both have similar numbers:

Ubuntu 20.04:

============================ 25461 passed, 2015 skipped, 10989 deselected, 75 xfailed, 7 xpassed, 10 warnings in 459.37s (0:07:39) =============================

Mac 10.15, Xcode 12

============================ 25497 passed, 1980 skipped, 10989 deselected, 75 xfailed, 6 xpassed, 10 warnings in 398.20s (0:06:38) =============================

[DaveWitteMorris]

Attachment: scipy-test-failure.txt

failure report

[DaveWitteMorris]

comment:11

In case it's any help: I ran scipy.test() inside sage (or, at least, I think that's what I did) and I seemed to get only one failure. It seems to be in test_hyperu_around_0 in test_mpmath.py. (The failure report from the end of the run is attached as scipy-test-failure.txt.) This is sage 9.2b12 on Mac OS 10.15.6. I think my XCode version is 11.0.

[dimpase]

comment:12

That Xcode 12 update raises the question whether the clang-12 - compiled code meant to be compatible with the clang-11 - compiled code, in particular C++ might be an issue.

[vbraun]

Changed branch from u/dimpase/packages/scipy/xcode12fix to 711fe05