Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src/module_list.py #30277

Closed
mkoeppe opened this issue Aug 3, 2020 · 14 comments
Closed

Remove src/module_list.py #30277

mkoeppe opened this issue Aug 3, 2020 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2020

#29701 made this file obsolete. We remove it.

Depends on #29701
Depends on #29950

CC: @dimpase @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch/Commit: df38027

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30277

@mkoeppe mkoeppe added this to the sage-9.2 milestone Aug 3, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2020

Branch: u/mkoeppe/remove_src_module_list_py

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2020

Changed dependencies from #29701 to #29701, #29950

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2020

Last 10 new commits:

08f5175Merge branch 'u/mkoeppe/change-src-bin-installation' of git://trac.sagemath.org/sage into t/29950/build_sagelib_using_installed_sage_setup
516358bbuild/pkgs/sagelib/src/tox.ini: Pass SAGE_LOCAL
5e577abMerge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
eaced09build/pkgs/sagelib: Add remaining Python dependencies for sage.all
b8e366ebuild/pkgs/sagelib/spkg-src: chmod +x
0473ef3Merge branch 't/21559/change-src-bin-installation' into t/29950/build_sagelib_using_installed_sage_setup
7244371Merge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
4344f89Merge branch 't/21559/change-src-bin-installation' into t/29950/build_sagelib_using_installed_sage_setup
01b96b0Merge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
2818739Merge branch 't/29950/build_sagelib_using_installed_sage_setup' into t/30277/remove_src_module_list_py

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2020

Commit: 2818739

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Aug 3, 2020

comment:5

it does not seem to work, all the pyx modules discovery is shot.
Perhaps I have not rebuilt enough. Is a sagelib rebuild sufficient?

@dimpase
Copy link
Member

dimpase commented Aug 3, 2020

comment:6

specifically, I cannot import src/sage/graphs/strongly_regular_db stuff

@dimpase
Copy link
Member

dimpase commented Aug 5, 2020

comment:7

OK, after a rebuild from scratch I see one doctest failing:

sage -t --random-seed=0 src/sage_setup/find.py
**********************************************************************
File "src/sage_setup/find.py", line 215, in sage_setup.find.find_extra_files
Failed example:
    extras["sage/ext/interpreters"]
Expected:
    ['.../src/sage/ext/interpreters/wrapper_cdf.pxd', ...wrapper_cdf.h...]
Got:
    ['/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rdf.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cdf.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rdf.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cdf.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cc.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_el.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rr.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cc.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_py.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_el.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rr.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_py.pxd']
**********************************************************************
1 item had failures:
   1 of   7 in sage_setup.find.find_extra_files
    [36 tests, 1 failure, 0.73 s]

@dimpase
Copy link
Member

dimpase commented Aug 5, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Aug 5, 2020

comment:9

here are all the instances of wrapper_cdf.h I have:

$ find . -name wrapper_cdf.h
./local/lib/python3.7/site-packages/sage/ext/interpreters/wrapper_cdf.h
./build/pkgs/sagelib/src/build/lib.linux-x86_64-3.7/sage/ext/interpreters/wrapper_cdf.h
./build/pkgs/sagelib/src/build/cythonized/sage/ext/interpreters/wrapper_cdf.h

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

8a19fe2build/make/Makefile.in (sagelib-clean): Clean the new build location
ccc67b0src/sage_setup: Update cythonized_dir in doctests
df38027Merge branch 't/29950/build_sagelib_using_installed_sage_setup' into t/30277/remove_src_module_list_py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2020

Changed commit from 2818739 to df38027

@dimpase
Copy link
Member

dimpase commented Aug 10, 2020

comment:12

ok

@vbraun
Copy link
Member

vbraun commented Aug 12, 2020

Changed branch from u/mkoeppe/remove_src_module_list_py to df38027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants