Install sage-env-config as part of sage_conf #29850

mkoeppe · 2020-06-12T20:01:36Z

As a follow-up to #21559 and #30128, we reassign sage-env-config from the package sagelib to the package sage_conf.

(After #22731, sage-env-config is no longer required by the sage script.)

(This is preparation for allowing installation of sagelib for example in a conda environment without having to run ./configure first - see #28745, #30845.)

Part of Meta-ticket #21707: Split sage-env into 5 to clean up sage configuration

Depends on #31002

CC: @jhpalmieri @kiwifb @orlitzky @dimpase @isuruf @tobiasdiez

Component: build

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: 4b52dcf

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29850

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-06-12T21:09:41Z

Dependencies: #29825

mkoeppe · 2020-06-12T21:43:07Z

Changed dependencies from #29825 to #29825, #21559

mkoeppe · 2020-06-13T00:30:17Z

Branch: u/mkoeppe/install_sage_env_config_with_sage_conf

mkoeppe · 2020-06-13T00:31:16Z

Changed dependencies from #29825, #21559 to #29825, #21559, #29803

mkoeppe · 2020-06-13T00:31:16Z

comment:4

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.

Last 10 new commits:

`70378ed`	`build/pkgs/pip/dependencies: Add wheel, simplify $(PYTHON) python3 to $(PYTHON)`
`10a2bac`	`build/pkgs/setuptools, build/pkgs/pip: Remove python2 support from dependencies, install scripts`
`6755adb`	`build/pkgs/pkgconfig/spkg-install.in: Remove pyproject.toml so that pip installs using setup.py`
`29327d3`	`build/pkgs/entrypoints: Do not provide setup.py, not needed for entrypoints 0.3`
`bcc79a5`	`build/pkgs/entrypoints/spkg-install.in: Remove pyproject.toml so that setup.py is used`
`361b98b`	`build/pkgs/terminado/spkg-install.in: Remove pyproject.toml so that setup.py is used`
`5040d7e`	`build/pkgs/testpath/spkg-install.in: Remove pyproject.toml so that setup.py is used`
`371ede6`	`build/pkgs/zope_interface: Change to a dummy script package`
`10a2bac`	`Merge branch 't/29803/upgrade_setuptools__pip__2020_06_' into t/29850/install_sage_env_config_with_sage_conf`
`dacea8b`	`WIP: Install sage-env-config with sage_conf`

mkoeppe · 2020-06-13T00:31:16Z

Commit: dacea8b

mkoeppe · 2020-06-13T00:31:57Z

comment:5

Perhaps it's easier to get rid of sage-env-config altogether (#29852).

mkoeppe · 2020-06-13T19:12:31Z

comment:7

Replying to @mkoeppe:

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.

Using flit instead of setuptools (#29854) does not help for this ticket because flit does not know how to install prepared shell scripts -- it can only install Python scripts

sagetrac-git · 2020-06-14T05:18:48Z

Changed commit from dacea8b to 5f7b1cc

sagetrac-git · 2020-06-14T05:18:48Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1ee054c`	`Fixup`
`5f7b1cc`	`Merge branch 't/21559/change-src-bin-installation' into t/29850/install_sage_env_config_with_sage_conf`

mkoeppe · 2020-06-14T05:24:37Z

comment:9

Replying to @mkoeppe:

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.

It would probably suffice to just replace the use of pip by setup.py install.

mkoeppe · 2020-06-24T03:02:20Z

Work Issues: use setup.py install, add spkg-src

sagetrac-git · 2020-06-24T04:28:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ae07682`	`Merge tag '9.2.beta1' into t/29850/install_sage_env_config_with_sage_conf`
`a4e4124`	`build/pkgs/sage_conf/spkg-install: Install with setup.py instead of pip`
`308ca69`	`build/pkgs/sage_conf/spkg-src: New`

sagetrac-git · 2020-06-24T04:28:08Z

Changed commit from 5f7b1cc to 308ca69

mkoeppe · 2020-06-24T04:42:12Z

Changed work issues from use setup.py install, add spkg-src to make sage-env-config optional for sage-env

mkoeppe · 2020-06-24T05:02:50Z

Changed work issues from make sage-env-config optional for sage-env to none

mkoeppe · 2020-06-24T05:03:06Z

Author: Matthias Koeppe

mkoeppe · 2020-06-28T20:04:49Z

Work Issues: Move sage_conf.py to SAGE_ROOT/src/, symlink to there

mkoeppe · 2020-06-28T20:35:23Z

comment:17

(comment was meant for a different ticket)

mkoeppe · 2020-07-02T22:26:05Z

Changed work issues from Move sage_conf.py to SAGE_ROOT/src/, symlink to there to none

sagetrac-git · 2020-07-04T18:44:31Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`3a0193c`	`src/bin/sage: Remove handling of 'sage -axiom'`
`6b04075`	`Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/change-src-bin-installation`
`9c7116b`	`src/bin/sage-list-optional, sage-list-experimental, sage-list-standard: Remove deprecated scripts`
`831cc09`	`Merge branch 't/29920/remove_deprecated_scripts_sage_list_optional__sage_list_experimental__sage_list_standard' into t/21559/change-src-bin-installation`
`e3eca85`	`Merge branch 'public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup' of git://trac.sagemath.org/sage into t/21559/change-src-bin-installation`
`7d29141`	`src/setup.py: Do not install removed script sage-rsyncdist`
`c5f7f2f`	`Merge tag '9.2.beta3' into t/21559/change-src-bin-installation`
`6bc0cd4`	`Install sage-env-config with sage_conf`
`5e6ca95`	`build/pkgs/sage_conf/spkg-install: Install with setup.py instead of pip`
`0330180`	`build/pkgs/sage_conf/spkg-src: New`

mkoeppe · 2020-11-12T18:34:53Z

Changed dependencies from #29951 to #29951 | #22731

mkoeppe · 2020-11-12T18:34:53Z

Work Issues: Rebase on top of #22731

sagetrac-git · 2020-11-14T00:27:26Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`4577f37`	`src/bin/sage-env: Make sage-env-config optional`
`c35c170`	`sage.env: Add SAGE_VENV`
`c585d94`	`src/sage: Replace some SAGE_LOCAL by SAGE_VENV`
`2fd195f`	`src/bin/sage: Fix reference to trac ticket`
`f3b7a9c`	`src/sage/env.py: Add documentation`
`0e4764c`	`Merge branch 't/22731/22731' into t/29850/install_sage_env_config_with_sage_conf`
`657eea0`	`Install sage-env-config with sage_conf`
`7e18730`	`build/pkgs/sage_conf/spkg-src: New`
`36e479c`	`build/pkgs/sagelib/src/setup.py: Do not install sage-env-config`
`5dc4266`	`build/pkgs/sage_conf/spkg-install: Build wheel manually`

sagetrac-git · 2020-11-14T00:27:26Z

Changed commit from 19f7eae to 5dc4266

mkoeppe · 2020-11-14T00:29:39Z

Changed dependencies from #29951 | #22731 to #22731

mkoeppe · 2020-11-14T00:29:39Z

Changed work issues from Rebase on top of #22731 to none

mkoeppe · 2020-12-06T17:45:17Z

Changed keywords from none to sd111

mkoeppe · 2020-12-06T21:12:27Z

Changed dependencies from #22731 to #31002

mkoeppe · 2020-12-06T21:12:27Z

Work Issues: use new function from #31002

mkoeppe · 2020-12-06T21:19:19Z

Changed work issues from use new function from #31002 to use new function from #31002 - or use #30013 and move sage-env-config into the sage_conf source directory

sagetrac-git · 2020-12-08T21:12:03Z

Changed commit from 5dc4266 to 4b52dcf

sagetrac-git · 2020-12-08T21:12:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a8e0364`	`Specify bdist temp folder for WSL compatibility`
`a3077c7`	`Use mktemp`
`c5a14a3`	`build/bin/sage-dist-helpers (sdh_setup_bdist_wheel): New`
`fb10429`	`build/pkgs/*/spkg-install.in: Use new function sdh_setup_bdist_wheel`
`5f11e24`	`Merge branch 'public/build/bdist_wsl' of git://trac.sagemath.org/sage into t/29850/install_sage_env_config_with_sage_conf`
`0773001`	`Merge tag '9.3.beta3' into t/29850/install_sage_env_config_with_sage_conf`
`4b52dcf`	`build/pkgs/sage_conf/spkg-install: Use sdh_setup_bdist_wheel`

mkoeppe · 2020-12-08T21:12:21Z

Changed work issues from use new function from #31002 - or use #30013 and move sage-env-config into the sage_conf source directory to none

mkoeppe · 2020-12-11T06:19:56Z

comment:45

Still needs review...

dimpase · 2020-12-11T11:35:31Z

comment:46

OK.

mkoeppe · 2020-12-11T16:15:05Z

comment:47

Thanks!

vbraun · 2020-12-13T20:31:04Z

Changed branch from u/mkoeppe/install_sage_env_config_with_sage_conf to 4b52dcf

mkoeppe added this to the sage-9.2 milestone Jun 12, 2020

mkoeppe added c: build labels Jun 12, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Install sage-env-config with sage_conf~~ Install sage-env-config as part of sage_conf Jun 13, 2020

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Jun 24, 2020

This comment has been minimized.

Sign in to view

mkoeppe added s: needs review and removed s: needs info labels Nov 14, 2020

mkoeppe changed the title ~~Install sage-env-config as part of sage_conf; make sage-env-config optional~~ Install sage-env-config as part of sage_conf Nov 14, 2020

mkoeppe added s: needs work and removed s: needs review labels Dec 6, 2020

mkoeppe added s: needs review and removed s: needs work labels Dec 8, 2020

dimpase added s: positive review and removed s: needs review labels Dec 11, 2020

vbraun removed the s: positive review label Dec 13, 2020

vbraun closed this as completed in c06aabc Dec 13, 2020

tobihan mentioned this issue Dec 5, 2020

Replace "$SAGE_LOCAL/bin" by more specific variables to make Sage easier to package, use in venvs #22731

Closed

Install sage-env-config as part of sage_conf #29850

Install sage-env-config as part of sage_conf #29850

Comments

mkoeppe commented Jun 12, 2020

This comment has been minimized.

mkoeppe commented Jun 12, 2020

mkoeppe commented Jun 12, 2020

mkoeppe commented Jun 13, 2020

mkoeppe commented Jun 13, 2020

mkoeppe commented Jun 13, 2020

mkoeppe commented Jun 13, 2020

mkoeppe commented Jun 13, 2020

mkoeppe commented Jun 13, 2020

sagetrac-git mannequin commented Jun 14, 2020

sagetrac-git mannequin commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

This comment has been minimized.

mkoeppe commented Jun 24, 2020

sagetrac-git mannequin commented Jun 24, 2020

sagetrac-git mannequin commented Jun 24, 2020

mkoeppe commented Jun 24, 2020

mkoeppe commented Jun 24, 2020

This comment has been minimized.

mkoeppe commented Jun 24, 2020

mkoeppe commented Jun 28, 2020

mkoeppe commented Jun 28, 2020

mkoeppe commented Jul 2, 2020

sagetrac-git mannequin commented Jul 4, 2020

mkoeppe commented Nov 12, 2020

mkoeppe commented Nov 12, 2020

sagetrac-git mannequin commented Nov 14, 2020

sagetrac-git mannequin commented Nov 14, 2020

mkoeppe commented Nov 14, 2020

mkoeppe commented Nov 14, 2020

This comment has been minimized.

mkoeppe commented Dec 6, 2020

mkoeppe commented Dec 6, 2020

mkoeppe commented Dec 6, 2020

mkoeppe commented Dec 6, 2020

sagetrac-git mannequin commented Dec 8, 2020

sagetrac-git mannequin commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 11, 2020

dimpase commented Dec 11, 2020

mkoeppe commented Dec 11, 2020

vbraun commented Dec 13, 2020