Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for FaceIterator_base #29681

Closed
kliem opened this issue May 13, 2020 · 11 comments
Closed

Small improvements for FaceIterator_base #29681

kliem opened this issue May 13, 2020 · 11 comments

Comments

@kliem
Copy link
Contributor

kliem commented May 13, 2020

This ticket collects some small improvements for the the class FaceIterator_base and the inherited classes FaceIterator, FaceIterator_geom:

  • Add a method reset.

  • Add a method current that retrieves the last value of __next__.

  • Simplify the methods ignore_subfaces and ignore_supfaces by outsourcing the common code to ignore_subsets.

    Follow up:

    Use face iterator to obtain the meet of (some) vertices or the join of (some) facets.

Depends on #29654

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedron, face iterator

Author: Jonathan Kliem

Branch/Commit: fc84ffa

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29681

@kliem kliem added this to the sage-9.1 milestone May 13, 2020
@kliem
Copy link
Contributor Author

kliem commented May 13, 2020

Branch: public/29681

@kliem
Copy link
Contributor Author

kliem commented May 13, 2020

Commit: f6633bd

@kliem
Copy link
Contributor Author

kliem commented May 13, 2020

Last 10 new commits:

53fd2a2fixed failing doctest
a6d2b2da face iterator subclass that yield PolyhedronFace
1476675representation like Polyhedron_base
47fc7cdaccount for FaceIterator -> FaceIterator_base
295039adocumentation
d36da4acoverage and small improvement
2d0f0d9method `reset` for the face iterator
6d99a4ctypo
5711f6bmethod `ignore_subsets`
f6633bdmethod current and fix for reset

@kliem kliem modified the milestones: sage-9.1, sage-9.2 May 13, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 13, 2020

comment:3

needs rebase

@kliem
Copy link
Contributor Author

kliem commented Aug 13, 2020

New commits:

3f92d2dfixed merge conflict
3ba34fdmove documenation to exposed class
d89a503Merge branch 'public/29654-reb3' of git://trac.sagemath.org/sage into public/29681-reb
fc84ffaMerge branch 'public/29681' of git://trac.sagemath.org/sage into public/29681-reb

@kliem
Copy link
Contributor Author

kliem commented Aug 13, 2020

Changed commit from f6633bd to fc84ffa

@kliem
Copy link
Contributor Author

kliem commented Aug 13, 2020

Changed branch from public/29681 to public/29681-reb

@tscrim
Copy link
Collaborator

tscrim commented Aug 30, 2020

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 30, 2020

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented Aug 30, 2020

comment:6

Thanks.

@vbraun
Copy link
Member

vbraun commented Sep 1, 2020

Changed branch from public/29681-reb to fc84ffa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants