-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements for FaceIterator_base
#29681
Milestone
Comments
Branch: public/29681 |
Commit: |
Last 10 new commits:
|
comment:3
needs rebase |
Changed branch from public/29681 to public/29681-reb |
comment:5
LGTM. |
Reviewer: Travis Scrimshaw |
comment:6
Thanks. |
Changed branch from public/29681-reb to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This ticket collects some small improvements for the the class
FaceIterator_base
and the inherited classesFaceIterator
,FaceIterator_geom
:Add a method
reset
.Add a method
current
that retrieves the last value of__next__
.Simplify the methods
ignore_subfaces
andignore_supfaces
by outsourcing the common code toignore_subsets
.Follow up:
Use face iterator to obtain the meet of (some) vertices or the join of (some) facets.
Depends on #29654
CC: @jplab @LaisRast
Component: geometry
Keywords: polyhedron, face iterator
Author: Jonathan Kliem
Branch/Commit:
fc84ffa
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/29681
The text was updated successfully, but these errors were encountered: