Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-check.in: Remove messages that duplicate sage-spkg's messages #29510

Closed
mkoeppe opened this issue Apr 15, 2020 · 8 comments
Closed

spkg-check.in: Remove messages that duplicate sage-spkg's messages #29510

mkoeppe opened this issue Apr 15, 2020 · 8 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 15, 2020

build/bin/sage-spkg already does:

        echo "Running the test suite for $PKG_NAME..."

and

            if [ "$SAGE_CHECK" = "warn" ]; then
                error_msg "Warning: Error testing package $PKG_NAME (ignored)" "make check"
            else
                error_msg "Error testing package $PKG_NAME" "make check"
                exit 1
            fi

So we remove the messages printed by individual spkg-check.in.

Depends on #29492

CC: @jhpalmieri @embray @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 9b213a4

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/29510

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 15, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2020

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

9b213a4build/bin/sage-spkg: Add message when test suite passed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2020

Commit: 9b213a4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2020

Author: Matthias Koeppe

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:5

Looks okay to me.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 18, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants