configure: Accept gcc/gfortran 10.x #29456

mkoeppe · 2020-04-03T13:44:42Z

As all build errors of standard packages with gcc/gfortran 10 have been fixed, we change the gcc and gfortran configure scripts to again accept these versions.

This ticket does not change the version of the gcc spkg.

Previous tickets:

gf2x: gf2x build fails on fedora-32-minimal #29390 gf2x build fails on fedora-32-minimal
SciPy: Upgrade to SciPy 1.2.3 (last release supporting py2 - Update scipy to 1.2.3 (last release supporting py2) #29443) does not fix it
Upgrade NumPy to 1.19.1, scipy to 1.5.2, networkx to 2.4, add pybind11 package #29766: Upgrade NumPy, scipy, networkx, add pybind11 package (dup: Upgrade NumPy to 1.18.5, scipy to 1.4.1, add pybind11 package #29425)
sympow: see Upgrade sympow to 2.023.6 (for GCC 10 support) #3360
palp: Update palp to 2.11 (for GCC 10 compatibility) #29859
gcc: fedora-32: If gcc 10 is found, install gcc spkg; fix building gcc (9.2.0) spkg with gcc 10 #29674: fedora-32: Building gcc (9.2.0) spkg fails with gcc 10
gfortran spkg-configure: Reject versions >= 10 #30067 gfortran spkg-configure: Reject versions >= 10

Related discussions:

Depends on #3360
Depends on #29766

CC: @dimpase @orlitzky @kiwifb @vbraun @enriqueartal @alexjbest @heluani @EmmanuelCharpentier

Component: porting

Keywords: sd109

Author: Matthias Koeppe

Branch: c898920

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/29456

The text was updated successfully, but these errors were encountered:

kiwifb · 2020-04-26T05:25:27Z

comment:3

Any more details on palp?

kiwifb · 2020-04-26T05:26:29Z

comment:4

Also, if we are targeting 9.2 we can move to higher scipy.

mkoeppe · 2020-04-26T06:33:51Z

comment:5

Replying to @kiwifb:

Any more details on palp?

For example here: https://github.com/mkoeppe/sage/runs/618646432?check_suite_focus=true

mkoeppe · 2020-04-26T06:35:20Z

comment:6

Replying to @kiwifb:

Also, if we are targeting 9.2 we can move to higher scipy.

As far as I can see there is no release yet with the fix

mkoeppe · 2020-04-26T06:36:14Z

comment:7

Question is whether we want to fix this for 9.1 already.

mkoeppe · 2020-04-26T18:55:49Z

comment:10

Presumably Fedora 32 has patched packages.

dimpase · 2020-04-27T02:03:29Z

comment:12

Replying to @mkoeppe:

Replying to @kiwifb:

Any more details on palp?

For example here: https://github.com/mkoeppe/sage/runs/618646432?check_suite_focus=true

2020-04-26T04:55:26.7728042Z   [palp-2.1.p2]   MoriCone.c: In function 'Triang2dSFan':
2020-04-26T04:55:26.7728579Z   [palp-2.1.p2]   MoriCone.c:489:48: warning: 'Z[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
2020-04-26T04:55:26.7729093Z   [palp-2.1.p2]     489 | #define BZangle(a,b) (ConeAngle(B.x[Z[a]],B.x[Z[b]])) // Gale-points
2020-04-26T04:55:26.7729654Z   [palp-2.1.p2]         |                                                ^
2020-04-26T04:55:26.7730199Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE   -c -o SingularInput.o SingularInput.c
2020-04-26T04:55:26.7730774Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -o poly.x poly.o Coord.o Rat.o Vertex.o Polynf.o LG.o
2020-04-26T04:55:26.7731343Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -o class.x class.o Coord.o Rat.o Vertex.o Polynf.o Subpoly.o Subadd.o Subdb.o
2020-04-26T04:55:26.7731892Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -o cws.x cws.o Coord.o Rat.o Vertex.o Polynf.o LG.o
2020-04-26T04:55:26.7732465Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -o nef.x nef.o Coord.o Rat.o Vertex.o Polynf.o E_Poly.o Nefpart.o LG.o
2020-04-26T04:55:26.7733264Z   [palp-2.1.p2]   gcc -O3 -W -Wall  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -o mori.x mori.o Coord.o Rat.o Vertex.o Polynf.o MoriCone.o SingularInput.o LG.o
2020-04-26T04:55:26.7733900Z   [palp-2.1.p2]   /usr/bin/ld: MoriCone.o:(.bss+0x0): multiple definition of `nr_SR_elements'; mori.o:(.bss+0x10): first defined here
2020-04-26T04:55:26.7734659Z   [palp-2.1.p2]   /usr/bin/ld: SingularInput.o:(.bss+0x0): multiple definition of `nr_SR_elements'; mori.o:(.bss+0x10): first defined here
2020-04-26T04:55:26.7735158Z   [palp-2.1.p2]   /usr/bin/ld: SingularInput.o: in function `HyperSurfSingular':
2020-04-26T04:55:26.7735673Z   [palp-2.1.p2]   SingularInput.c:(.text+0x1e1): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
2020-04-26T04:55:26.7736112Z   [palp-2.1.p2]   collect2: error: ld returned 1 exit status
2020-04-26T04:55:26.7736565Z   [palp-2.1.p2]   make[4]: *** [Makefile:50: mori] Error 1
2020-04-26T04:55:26.7737028Z   [palp-2.1.p2]   make[4]: Target 'all' not remade because of errors.
2020-04-26T04:55:26.7737532Z   [palp-2.1.p2]   make[4]: Leaving directory '/sage/local/var/tmp/sage/build/palp-2.1.p2/src'
2020-04-26T04:55:26.7738036Z   [palp-2.1.p2]   ********************************************************************************
2020-04-26T04:55:26.7738482Z   [palp-2.1.p2]   Error building palp-2.1.p2

before the logs exprire...

enriqueartal · 2020-05-11T06:34:16Z

comment:19

Besides the packages cited in the description (cannot say about gf2x) gap_packages does not build, due to cohomolo package.

timokau · 2020-05-19T14:29:25Z

comment:20

Palp 2.11 mentions gcc 10 compatibility:

palp-2.11.tar.gz: Small change in Mori.h for compatibility with gcc_10 and other minor patches (thanks to J. Puydt) [May 18, 2020].

-- http://hep.itp.tuwien.ac.at/~kreuzer/CY/CYpalp.html

timokau · 2020-05-19T15:46:43Z

comment:21

Unfortunately I'm not sure if the upstream source tarball for palp 2.11 is finalized though. Since I've packaged it 3 days ago (NixOS/nixpkgs#87944) the tarball silently changed.

kiwifb · 2020-05-19T19:57:36Z

comment:22

Replying to @timokau:

Unfortunately I'm not sure if the upstream source tarball for palp 2.11 is finalized though. Since I've packaged it 3 days ago (NixOS/nixpkgs#87944) the tarball silently changed.

I just adopted the patch already shipped in fedora until a new release.

sympow is fixed by upgrading to the new fork.
scipy can be fixed by adding some fortran flags until they fix the code, -std=legacy I think. I otherwise built sage-on-gentoo successfully with gcc-10 but I am not sure I have scanned absolutely all the packages.

timokau · 2020-05-28T15:06:11Z

comment:23

For what it's worth, upstream confirmed that palp 2.11 is stable and no further changes are expected.

mkoeppe · 2020-05-28T18:19:32Z

Changed keywords from none to sd109

mkoeppe · 2020-06-14T19:21:40Z

comment:25

I have opened #29859 for palp

mkoeppe · 2020-07-14T16:55:11Z

comment:41

Tests running at https://github.com/mkoeppe/sage/actions/runs/168165380

sagetrac-git · 2020-07-14T17:03:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d39817f`	`build/pkgs/numpy: Downgrade to 1.18.5 to fix build error on debian-jessie`
`879375b`	`Merge branch 't/29766/packages/networkx24' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`
`a17c655`	`m4/sage_spkg_collect.m4: Do not include script packages in SAGE_SDIST_PACKAGES`
`827923a`	`bootstrap: Accept 2020s in config.guess version check`
`c30ac54`	`tox.ini: Add local-nobootstrap`
`de6464d`	`.github/workflows/tox.yml: Add jobs "dist", "local-macos-nohomebrew`
`775b7f7`	`Trac #30088: add a few explanatory comments to m4/sage_spkg_collect.m4.`
`160862f`	`m4/sage_spkg_collect.m4: Mention sagelib in the comment`
`d1a2cbf`	`Merge branch 't/30088/fix__make_sdist___add_test_run_to_github_actions' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda`
`7cf9a5c`	`Merge branch 't/29929/tox_ini__add_a_macos_environment_without_homebrew__conda' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`

sagetrac-git · 2020-07-14T17:03:38Z

Changed commit from e5bf863 to 7cf9a5c

sagetrac-git · 2020-07-14T22:53:17Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fcddf69`	`Revert "build/pkgs/numpy: Downgrade to 1.18.5 to fix build error on debian-jessie"`
`3558737`	`build/pkgs/numpy/patches/16871.patch: New`
`4e6d8a3`	`Merge branch 't/29766/packages/networkx24' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`

sagetrac-git · 2020-07-14T22:53:17Z

Changed commit from 7cf9a5c to 4e6d8a3

sagetrac-git · 2020-07-15T05:50:36Z

Changed commit from 4e6d8a3 to 2035df2

sagetrac-git · 2020-07-15T05:50:36Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ba0ccb6`	`Experimental: Use numpy PR 16871`
`c24d109`	`build/pkgs/cython: Updatt to 0.29.21`
`79bf297`	`Merge branch 't/29861/upgrade_cython_to_0_29_20' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`
`2035df2`	`Fixup: Experimental: Use numpy PR 16871`

mkoeppe · 2020-08-07T19:32:18Z

Changed dependencies from #3360, #29766, #29929, #30118 to #3360, #29766

sagetrac-git · 2020-08-07T19:34:32Z

Changed commit from 2035df2 to 95e8a22

sagetrac-git · 2020-08-07T19:34:32Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`56fe1c2`	`Merge branch 't/3360/sympow-2.23.2' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`
`1bf6249`	`Update numpy to 1.19.1, add patches`
`061e975`	`Merge branch 'u/mkoeppe/upgrade_cython_to_0_29_20' of git://trac.sagemath.org/sage into t/29766/packages/networkx24`
`fc7592c`	`Merge branch 't/29929/tox_ini__add_a_macos_environment_without_homebrew__conda' into t/29766/packages/networkx24`
`7fe5985`	`right place for warnings.filterwarnings() for networkx & scipy`
`5fa0bba`	`build/pkgs/scipy: Update to 1.5.2`
`3890e1a`	`build/make/Makefile.in: Improve handling of SAGE_CHECK_PACKAGES`
`5d4b013`	`build/make/Makefile.in: Handle the case in which SAGE_CHECK_PACKAGES is set using a command argument`
`fb9806a`	`Merge branch 't/29766/packages/networkx24' into t/29456/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_`
`95e8a22`	`build/pkgs/{gcc,gfortran}/spkg-configure.m4: Accept gcc 10.x`

mkoeppe · 2020-08-07T19:36:09Z

comment:49

Re-enabled gcc 10. Tests run at https://github.com/mkoeppe/sage/actions/runs/199625493

sagetrac-git · 2020-08-10T16:16:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c898920`	`build/pkgs/gcc/spkg-configure.m4: Fixup`

sagetrac-git · 2020-08-10T16:16:33Z

Changed commit from 95e8a22 to c898920

enriqueartal · 2020-08-11T15:13:50Z

comment:51

I have just built it successfully. It failed the installation of gap_packages because of package cohomolo but it also fails to compile in gap itself.

mkoeppe · 2020-08-11T15:17:43Z

comment:52

Thanks for testing!

If there's no ticket for gap_packages yet, could you open one please?

dimpase · 2020-08-11T15:41:07Z

comment:53

Replying to @mkoeppe:

Thanks for testing!

If there's no ticket for gap_packages yet, could you open one please?

I just opened gap-packages/cohomolo#24
(verified that it's a problem with gcc-10 on Gentoo)

vbraun · 2020-08-18T23:05:51Z

Author: Matthias Koeppe

vbraun · 2020-08-18T23:05:51Z

Reviewer: Volker Braun

mkoeppe · 2020-08-19T00:01:54Z

comment:57

Thanks.

EmmanuelCharpentier · 2020-08-19T13:58:12Z

comment:58

Replying to @vbraun:

FWIW, worked for me for the upgrade to 9.2.beta9...

vbraun · 2020-08-20T22:23:01Z

Changed branch from u/mkoeppe/meta_ticket__support_gcc_10__needed_for_fedora_32_build__released_end_of_april_2020_ to c898920

dimpase · 2020-08-23T08:34:57Z

comment:60

this seems not to be in beta9, right? should it be in beta10?

dimpase · 2020-08-23T08:34:57Z

Changed commit from c898920 to none

mkoeppe added this to the sage-9.2 milestone Apr 3, 2020

mkoeppe added c: porting labels Apr 3, 2020

mkoeppe added p: critical / 2 and removed p: major / 3 labels Apr 26, 2020

mkoeppe changed the title ~~Meta-ticket: Support gcc 10 (fedora-32)~~ Meta-ticket: Support gcc 10, needed for fedora-32 build (scheduled to be released end of April 2020) Apr 26, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Meta-ticket: Support gcc 10, needed for fedora-32 build (scheduled to be released end of April 2020)~~ Meta-ticket: Support gcc 10, needed for fedora-32 build (released end of April 2020) May 10, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Meta-ticket: Support gcc/gfortran 10~~ configure: Accept gcc/gfortran 10.x Aug 18, 2020

mkoeppe added the s: needs review label Aug 18, 2020

vbraun added s: positive review and removed s: needs review labels Aug 18, 2020

vbraun removed the s: positive review label Aug 20, 2020

vbraun closed this as completed in 2175895 Aug 20, 2020

configure: Accept gcc/gfortran 10.x #29456

configure: Accept gcc/gfortran 10.x #29456

Comments

mkoeppe commented Apr 3, 2020

kiwifb commented Apr 26, 2020

kiwifb commented Apr 26, 2020

mkoeppe commented Apr 26, 2020

mkoeppe commented Apr 26, 2020

mkoeppe commented Apr 26, 2020

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Apr 26, 2020

This comment has been minimized.

dimpase commented Apr 27, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

enriqueartal commented May 11, 2020

timokau commented May 19, 2020

timokau commented May 19, 2020

kiwifb commented May 19, 2020

timokau commented May 28, 2020

mkoeppe commented May 28, 2020

This comment has been minimized.

mkoeppe commented Jun 14, 2020

This comment has been minimized.

mkoeppe commented Jul 14, 2020

sagetrac-git mannequin commented Jul 14, 2020

sagetrac-git mannequin commented Jul 14, 2020

sagetrac-git mannequin commented Jul 14, 2020

sagetrac-git mannequin commented Jul 14, 2020

sagetrac-git mannequin commented Jul 15, 2020

sagetrac-git mannequin commented Jul 15, 2020

mkoeppe commented Aug 7, 2020

sagetrac-git mannequin commented Aug 7, 2020

sagetrac-git mannequin commented Aug 7, 2020

mkoeppe commented Aug 7, 2020

sagetrac-git mannequin commented Aug 10, 2020

sagetrac-git mannequin commented Aug 10, 2020

enriqueartal commented Aug 11, 2020

mkoeppe commented Aug 11, 2020

dimpase commented Aug 11, 2020

This comment has been minimized.

vbraun commented Aug 18, 2020

vbraun commented Aug 18, 2020

mkoeppe commented Aug 19, 2020

EmmanuelCharpentier mannequin commented Aug 19, 2020

vbraun commented Aug 20, 2020

dimpase commented Aug 23, 2020

dimpase commented Aug 23, 2020