Bug in incidence_matrix of CombinatorialPolyhedron

[LaisRast]

The incidence_matrix method of a 0-dimensional CombinatorialPolyhedron returns an error:

sage: P = Polyhedron([[0]]); P
A 0-dimensional polyhedron in ZZ^1 defined as the convex hull of 1 vertex
sage: C = P.combinatorial_polyhedron()
sage: C.incidence_matrix()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-7-dab311ba238f> in <module>()
----> 1 C.incidence_matrix()
...
ValueError: ``output_dimension`` must be the dimension of proper faces

We fix this and make the 0-dimensional case consistent with Polyhedron_base.

Also we make incidence_matrix a chached_method.

CC: @jplab @kliem

Component: geometry

Keywords: polytope, combinatorialpolyhedron, incidence_matrix

Author: Jonathan Kliem

Branch/Commit: 34f3254

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29455

[kliem]

New commits:

4aa8b28

fix incidence matrix for small combinatorial polyhedra

[kliem]

Author: Jonathan Kliem

[kliem]

Commit: 4aa8b28

[kliem]

Branch: public/29455

[LaisRast]

comment:2

This fixes the problem.

[LaisRast]

Reviewer: Laith Rastanawi

[kliem]

comment:3

Thanks

[vbraun]

comment:4

See patchbots:

sage -t --long src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx  # 2 doctests failed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

34f3254

typos in doctests

[sagetrac-git]

Changed commit from 4aa8b28 to 34f3254

[kliem]

comment:6

I'm sorry. I really don't know how that could have happened. It didn't even work for me.

[LaisRast]

comment:7

Sorry, it is my mistake since I put it on "positive review".
Now the tests look fine. So I will but it again on "positive review".

[vbraun]

Changed branch from public/29455 to 34f3254