Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute lookup in _coerce_map_from_base_ring() for Cython classes #29312

Closed
pjbruin opened this issue Mar 11, 2020 · 5 comments
Closed

Fix attribute lookup in _coerce_map_from_base_ring() for Cython classes #29312

pjbruin opened this issue Mar 11, 2020 · 5 comments
Labels
c: coercion p: minor / 4 t: bug
Milestone
sage-9.1

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Mar 11, 2020

Reported by Markus Wageringel in #29247 comment:14:

sage: F.<x,y,z> = FreeAlgebra(QQ, implementation='letterplace')
sage: F._coerce_map_from_base_ring()
...
AttributeError: type object 'sage.algebras.letterplace.free_algebra_letterplace' has no attribute 'from_base_ring'

CC: @mwageringel @tscrim

Component: coercion

Author: Peter Bruin

Branch/Commit: c4631b6

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29312
@pjbruin pjbruin added this to the sage-9.1 milestone Mar 11, 2020
@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 11, 2020

Branch: u/pbruin/29312-from_base_ring

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 11, 2020

Commit: c4631b6

@mwageringel
Copy link

comment:2

This looks good to me. Thanks.

@mwageringel
Copy link

Reviewer: Markus Wageringel

@vbraun
Copy link
Member

vbraun commented Mar 12, 2020

Changed branch from u/pbruin/29312-from_base_ring to c4631b6

@vbraun vbraun closed this as completed in 33ec6fe Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @pjbruin @mwageringel