Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards compatibility broken by #29247 #29303

Closed
pjbruin opened this issue Mar 9, 2020 · 5 comments
Closed

Fix backwards compatibility broken by #29247 #29303

pjbruin opened this issue Mar 9, 2020 · 5 comments
Labels
c: coercion p: major / 3 t: bug
Milestone
sage-9.1

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Mar 9, 2020

In #29247, the _no_generic_basering_coercion flag was deprecated, but its effect (not executing UnitalAlgebras.ParentMethods.__init_first__) was accidentally nullified. Thanks to Marc Mezzarobba for reporting this.

Component: coercion

Author: Peter Bruin

Branch/Commit: a7bb5c1

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/29303
@pjbruin pjbruin added this to the sage-9.1 milestone Mar 9, 2020
@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 9, 2020

Commit: a7bb5c1

@pjbruin
Copy link
Contributor Author

pjbruin commented Mar 9, 2020

Branch: u/pbruin/29303-backwards_compatibility

@mezzarobba
Copy link
Member

comment:2

Thank you!

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Mar 11, 2020

Changed branch from u/pbruin/29303-backwards_compatibility to a7bb5c1

@vbraun vbraun closed this as completed in 856618a Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @mezzarobba @pjbruin