-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctest in padic_lattice_element.py gives error in current develop branch #29272
Comments
comment:2
see #20601 for some old related ticket |
comment:4
Strange that this would only be noticed now? New commits:
|
Commit: |
Author: Matthias Koeppe |
comment:6
With this branch, we're getting test failures on the patchbot where the FutureWarnings appear, so we clearly can't just remove them. I'm not sure why they appear sometime and not other times.... |
comment:7
Are the doctests in one block like this parallelized? |
comment:8
No, they should be run in series since they're within one block. |
comment:9
Another solution (that I should check with Xavier and Julian about) is to remove the experimental designation. We haven't worked on the lattice precision interface for a while, so maybe we should just think about what interface changes we want to make, make them, and then remove these warnings. We've got a work week planned in mid April where we could look into this. |
comment:10
Replying to @roed314:
what is so special about this bot? |
comment:13
This issue does not occur when running the long tests, but only when running the short tests, so this is not a problem on the patchbots. This might be a weird interaction between the doctest framework filtering duplicate warnings and the This problem can be solved by reordering the doctests, so that the long test cases are executed after the short ones. Here is a branch that does this. New commits:
|
Changed author from Matthias Koeppe to Markus Wageringel |
comment:14
LGTM. (Lowering the stacklevel to 3 would have worked as well, but this is so much simpler). |
Reviewer: Jonathan Kliem |
Changed branch from u/gh-mwageringel/29272 to |
This is the error when doctesting in src/sage/rings/padics/padic_lattice_element.py:
Probably requires a simple change in the doctest.
CC: @kedlaya @edgarcosta @tscrim @roed314 @fchapoton @xcaruso @saraedum @dimpase @sagetrac-dlucas @dkrenn @sagetrac-tmonteil @johanrosenkilde @kliem
Component: padics
Author: Markus Wageringel
Branch/Commit:
73e82fa
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29272
The text was updated successfully, but these errors were encountered: