-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix package information, extend dockerfile generator to nix #29130
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
Commit: |
comment:4
This defines For New commits:
|
comment:5
Regarding the package equivalents: All packages sage needs should be listed at the start of one of those files:
One caveat is that if you want to use system python packages, you either need to add them to PYTHONPATH manually or install them as a single python environment. That means instead of installing I'm happy to help by explaining things, though I won't take the lead on this for now since sage-the-distribution isn't high priority for me right now (I have my hands full keeping the nix package running). |
comment:6
Replying to @timokau:
Thanks.
For now, we are not taking care of any Python packages. |
comment:7
pushing these forward to 9.2 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:9
Rebased on 9.2.beta1 |
comment:10
Starting points for people who want to help with this: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Dependencies: #30044 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:20
Let's get this in please |
comment:21
I'm running a few tests here: https://github.com/kliem/sage/pull/24/checks |
comment:22
python3 isn't picked up, which isn't very surprising by the above comment. I guess this can be done in a future ticket. It is not recognized that gcc contains a fortran compiler. But that is maybe also a future ticket.
|
comment:23
This is pretty much good to go. I think only the last point should be handled here, shouldn't it? |
Reviewer: Jonathan Kliem |
comment:25
Thank you! |
Changed branch from u/gh-kliem/add_nix_package_information__extend_dockerfile_generator_to_nix to |
This extends #29053, where it is done for debian/fedora/conda/arch.
https://hub.docker.com/r/nixos/nix/
https://wiki.sagemath.org/Distribution#Nix
To test:
Depends on #30044
CC: @timokau @dimpase @kliem
Component: build
Author: Matthias Koeppe
Branch/Commit:
d4b2af2
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29130
The text was updated successfully, but these errors were encountered: