Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix package information, extend dockerfile generator to nix #29130

Closed
mkoeppe opened this issue Jan 31, 2020 · 36 comments
Closed

Add nix package information, extend dockerfile generator to nix #29130

mkoeppe opened this issue Jan 31, 2020 · 36 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 31, 2020

This extends #29053, where it is done for debian/fedora/conda/arch.

https://hub.docker.com/r/nixos/nix/

https://wiki.sagemath.org/Distribution#Nix

To test:

  tox -e docker-nixos-minimal
  tox -e docker-nixos-standard

Depends on #30044

CC: @timokau @dimpase @kliem

Component: build

Author: Matthias Koeppe

Branch/Commit: d4b2af2

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29130

@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 31, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2020

Commit: a3d21ce

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2020

comment:4

This defines docker-nixos-minimal.

For docker-nixos-standard, need to add many package equivalences to build/pkgs/*/distros/nix.txt


New commits:

a3d21ceAdd Dockerfile generator, basic package information for nix

@timokau
Copy link
Contributor

timokau commented Mar 10, 2020

comment:5

Regarding the package equivalents: All packages sage needs should be listed at the start of one of those files:

One caveat is that if you want to use system python packages, you either need to add them to PYTHONPATH manually or install them as a single python environment. That means instead of installing
python3, numpy, scipy
separately, you'd install the "package" (or environment) python3.withPackages (ps: with ps; [numpy scipy]).

I'm happy to help by explaining things, though I won't take the lead on this for now since sage-the-distribution isn't high priority for me right now (I have my hands full keeping the nix package running).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 17, 2020

comment:6

Replying to @timokau:

Regarding the package equivalents: All packages sage needs should be listed at the start of one of those files:

Thanks.

One caveat is that if you want to use system python packages, ...

For now, we are not taking care of any Python packages.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 14, 2020

comment:7

pushing these forward to 9.2

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b88ec28Add Dockerfile generator, basic package information for nix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2020

Changed commit from a3d21ce to b88ec28

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

comment:9

Rebased on 9.2.beta1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

comment:10

Starting points for people who want to help with this:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Changed commit from b88ec28 to cf4ff83

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

49bdc21tox.ini: Add voidlinux
e01c37dbuild/pkgs/void-bootstrap.txt: New
0faf817build/bin/write-dockerfile.sh [voidlinux]: Fix typo
bc5c2dbMerge branch 't/30064/fix_tox_docker_builds_broken_by__29884' into t/30044/tox_ini__test_on_voidlinux
8043c9cbuild/pkgs/void-bootstrap.txt: Add gettext-devel
f2fe15bMerge tag '9.2.beta5' into t/30044/tox_ini__test_on_voidlinux
83c240eAdd more voidlinux packages
9f4a232Add voidlinux package for giac
d43730cremove glib2 (typo?)
cf4ff83Merge branch 't/30044/tox_ini__test_on_voidlinux' into t/29130/add_nix_package_information__extend_dockerfile_generator_to_nix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bfb52bebuild/bin/write-dockerfile.sh [nix]: Fixup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Changed commit from cf4ff83 to bfb52be

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 11, 2020

Dependencies: #30044

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

15cd368build/pkgs/*/distros/nix.txt: Add from sagelib.nix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Changed commit from bfb52be to 15cd368

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Changed commit from 15cd368 to 7c9bf82

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

7c9bf82build/pkgs/*/distros/nix.txt: Add from sage-env.nix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Changed commit from 7c9bf82 to 0a639c4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

0a639c4build/pkgs/r/distros/nix.txt: rWrapper does not exist, use R

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2020

comment:20

Let's get this in please

@kliem
Copy link
Contributor

kliem commented Aug 24, 2020

comment:21

I'm running a few tests here: https://github.com/kliem/sage/pull/24/checks

@kliem
Copy link
Contributor

kliem commented Aug 25, 2020

comment:22

python3 isn't picked up, which isn't very surprising by the above comment. I guess this can be done in a future ticket.

It is not recognized that gcc contains a fortran compiler. But that is maybe also a future ticket.

libgd fails to install, which is somewhat unfortunate as we could simply add the package freetype to the system, couldn't we?

@kliem
Copy link
Contributor

kliem commented Aug 25, 2020

comment:23

This is pretty much good to go. I think only the last point should be handled here, shouldn't it?

@kliem
Copy link
Contributor

kliem commented Aug 26, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Aug 26, 2020

Changed commit from 0a639c4 to d4b2af2

@kliem
Copy link
Contributor

kliem commented Aug 26, 2020

comment:24

I added freetype. If you agree, this is a positive review.


New commits:

b10493cMerge branch 'u/mkoeppe/add_nix_package_information__extend_dockerfile_generator_to_nix' of git://trac.sagemath.org/sage into test_29130
d4b2af2reviewer commit

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 26, 2020

comment:25

Thank you!

@vbraun
Copy link
Member

vbraun commented Aug 30, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants