Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stack method of Polyhedron use fraction_field #29057

Closed
LaisRast opened this issue Jan 20, 2020 · 14 comments
Closed

make stack method of Polyhedron use fraction_field #29057

LaisRast opened this issue Jan 20, 2020 · 14 comments

Comments

@LaisRast
Copy link

stack method of Polyhedron has the following behavior:

sage: P = polytopes.cross_polytope(4)
sage: P.stack(P.faces(3)[0])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
...
TypeError: no conversion of this rational to integer

We fix this by extending the base_ring of locus_polyhedron to its fraction_field.

CC: @jplab @kliem

Component: geometry

Keywords: polytopes, stack

Author: Laith Rastanawi

Branch/Commit: ac7882e

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29057

@LaisRast LaisRast added this to the sage-9.1 milestone Jan 20, 2020
@LaisRast
Copy link
Author

New commits:

b717357 make stack method of Polyhedron use fraction_field

@LaisRast
Copy link
Author

Branch: public/29057

@LaisRast
Copy link
Author

Author: Laith Rastanawi

@LaisRast
Copy link
Author

Commit: b717357

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2020

Changed commit from b717357 to add3c82

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

adc4ca4fix testing ticket number
add3c82old parent changes to an appropriate base_ring

@LaisRast

This comment has been minimized.

@LaisRast

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Jan 21, 2020

comment:5

Looks fine. Maybe you can add backend=self.backend() for locus polyhedron.

As the inequalities and equations are taken from our original polyhedron, the backend can always handle locus polyhedron.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2020

Changed commit from add3c82 to ac7882e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

ac7882euse self.backend() in locus_polyhedron

@kliem
Copy link
Contributor

kliem commented Jan 21, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jan 21, 2020

comment:7

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 25, 2020

Changed branch from public/29057 to ac7882e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants