-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make stack method of Polyhedron use fraction_field #29057
Labels
Milestone
Comments
New commits:
|
Branch: public/29057 |
Author: Laith Rastanawi |
Commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:5
Looks fine. Maybe you can add As the inequalities and equations are taken from our original polyhedron, the backend can always handle locus polyhedron. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Jonathan Kliem |
comment:7
LGTM. |
Changed branch from public/29057 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
stack
method ofPolyhedron
has the following behavior:We fix this by extending the
base_ring
oflocus_polyhedron
to itsfraction_field
.CC: @jplab @kliem
Component: geometry
Keywords: polytopes, stack
Author: Laith Rastanawi
Branch/Commit:
ac7882e
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29057
The text was updated successfully, but these errors were encountered: