Make RDF round and friends return Integers

[jasongrout]

> Also, round(RR(3.0)) returns an Integer...should RDF behave the same
> > way? (currently round(RDF(3.0)) returns an RDF).

We recently changed round, floor, ceiling, and trunc on RR to return
integers; yes, I think the corresponding RDF methods should change as
well.

Carl

Component: coercion

Issue created by migration from https://trac.sagemath.org/ticket/2899

[jasongrout]

comment:1

The fix for #2898 will fix this.

[ncalexan]

comment:2

Attachment: 2899-ncalexan-RIF-floor-ceil-1.patch.gz

This makes floor and ceil do what I expect for RIF. I believe that #2898 does make RDF work.

[craigcitro]

comment:3

I just tried to apply this against 3.2, and it fails. It's just a matter of moving the doctests around, I think.

[robertwb]

comment:4

This appears to have already been fixed.

----------------------------------------------------------------------
| Sage Version 3.4.2, Release Date: 2009-05-05                       |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

sage: a = RDF(3.4)

sage: a.round(), a.floor(), a.ceil()
 (3, 3, 4)

[sagetrac-mabshoff]

comment:5

Did someone add a doctest? Otherwise this should not have been closed.

Cheers,

Michael

[sagetrac-mabshoff]

comment:6

Reopening until someone either points to a doctests or post a doctest patch.

Cheers,

Michael

[ncalexan]

comment:7

There are doctests for RDF for sure:

    def round(self):
        """
        Given real number x, rounds up if fractional part is greater than
        .5, rounds down if fractional part is less than .5.

        EXAMPLES::
        
            sage: RDF(0.49).round()
            0
            sage: a=RDF(0.51).round(); a
            1
        """
        return Integer(round(self._value))

    def floor(self):
        """
        Returns the floor of this number
        
        EXAMPLES::
        
            sage: RDF(2.99).floor()
            2
            sage: RDF(2.00).floor()
            2
            sage: RDF(-5/2).floor()
            -3
        """
        return Integer(math.floor(self._value))

    def ceil(self):
        """
        Returns the ceiling of this number
        
        OUTPUT: integer
        
        EXAMPLES::
        
            sage: RDF(2.99).ceil()
            3
            sage: RDF(2.00).ceil()
            2
            sage: RDF(-5/2).ceil()
            -2
        """
        return Integer(math.ceil(self._value))

[sagetrac-mabshoff]

comment:8

Excellent. Closed as fixed.

Cheers,

Michael

[sagetrac-mabshoff]

comment:9

Wait. There are doctests via Nick's ticket, but that patch has not been merged into the Sage library, but fixed in some other way, i.e. the symbolics switch in 4.0. I assume.

In that case we might still need doctests, so until this is sorted out I am reopening this again :(

Cheers,

Michael

[robertwb]

comment:11

There are doctests.