Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "high mem" to "memlimit" when referring to doctesting tags #28978

Closed
jhpalmieri opened this issue Jan 10, 2020 · 8 comments
Closed

Change "high mem" to "memlimit" when referring to doctesting tags #28978

jhpalmieri opened this issue Jan 10, 2020 · 8 comments
Labels
c: doctest framework p: minor / 4 t: bug
Milestone
sage-9.1

Comments

@jhpalmieri
Copy link
Member

Tagging a doctest "high mem" doesn't do anything: it should be tagged "memlimit" instead. But a few places in the Sage code still say "high mem".

Component: doctest framework

Author: John Palmieri

Branch/Commit: 0bbdcdf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28978
@jhpalmieri jhpalmieri added this to the sage-9.1 milestone Jan 10, 2020
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/memlimit

@jhpalmieri
Copy link
Member Author

New commits:

e247a3dtrac 28979: change "high mem" to "memlimit"

@jhpalmieri
Copy link
Member Author

Commit: e247a3d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0bbdcdftrac 28979: change "high mem" to "memlimit"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2020

Changed commit from e247a3d to 0bbdcdf

@tscrim
Copy link
Collaborator

tscrim commented Jan 14, 2020

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 14, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/jhpalmieri/memlimit to 0bbdcdf

@vbraun vbraun closed this as completed in 9a911b0 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jhpalmieri