Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron: Let affine hull fully respect backend #28876

Closed
kliem opened this issue Dec 12, 2019 · 6 comments
Closed

Polyhedron: Let affine hull fully respect backend #28876

kliem opened this issue Dec 12, 2019 · 6 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.0

Comments

@kliem
Copy link
Contributor

kliem commented Dec 12, 2019

The method affine hull does not preserve backend, when orthogonal or orthonormal is True.

We fix this.

normaliz should be able to handle most base rings that appear with this method, so this is mostly usefull for the backend normaliz.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, backend, affine hull

Author: Jonathan Kliem

Branch/Commit: 2cb50f4

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28876
@kliem kliem added this to the sage-9.0 milestone Dec 12, 2019
@kliem
Copy link
Contributor Author

kliem commented Dec 12, 2019

Commit: 2cb50f4

@kliem
Copy link
Contributor Author

kliem commented Dec 12, 2019

Branch: public/28876

@kliem
Copy link
Contributor Author

kliem commented Dec 12, 2019

New commits:

2cb50f4affine hull preservers backend if orthogonal or orthonormal

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@LaisRast
Copy link

comment:2

It looks good to me.
I will put it on positive review once the patchbots are done.

@vbraun
Copy link
Member

vbraun commented Dec 17, 2019

Changed branch from public/28876 to 2cb50f4

@vbraun vbraun closed this as completed in c49ab24 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
3 participants
@vbraun @kliem @LaisRast