Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polar of integer polytopes does not respect backend #28851

Closed
kliem opened this issue Dec 6, 2019 · 7 comments
Closed

Polar of integer polytopes does not respect backend #28851

kliem opened this issue Dec 6, 2019 · 7 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.0

Comments

@kliem
Copy link
Contributor

kliem commented Dec 6, 2019

Currently, polytopes over the integers have there own method for polar, which does not respect the given backend:

sage: polytopes.cube(backend='normaliz').polar().backend()
'ppl'

We add the backend to the constructor to fix this. Any backend that can handle ZZ can also handle QQ.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, polar

Author: Jonathan Kliem

Branch/Commit: 50bbb76

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28851
@kliem kliem added this to the sage-9.0 milestone Dec 6, 2019
@kliem

This comment has been minimized.

Sign in to view
@kliem
Copy link
Contributor Author

kliem commented Dec 6, 2019

Commit: 50bbb76

@kliem
Copy link
Contributor Author

kliem commented Dec 6, 2019

Branch: public/28851

@kliem
Copy link
Contributor Author

kliem commented Dec 6, 2019

New commits:

50bbb76polar of polytope over integers respects backend

@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2019

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 16, 2019

Changed branch from public/28851 to 50bbb76

@vbraun vbraun closed this as completed in 4147813 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @kliem