-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: fix doctests with gurobi #28756
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:2
if you have gurobi, your help reviewing this ticket will be appreciated ;) |
comment:3
When Gurobi is the default your branch also fixes many other failures:
Let me update the description of the ticket. |
This comment has been minimized.
This comment has been minimized.
Reviewer: Sébastien Labbé |
comment:6
Cool, more problems fixed than expected ;) |
Changed branch from public/linear_programming/28756_gurobi to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With sage 9.0.beta6 and gurobi, we get 17 failing doctests due to str vs bytes (
TypeError: expected bytes, str found
), char vs str, and the change of behavior of zip between py2 and py3 (TypeError: object of type 'zip' has no len()
). Some problems were fixed in #28206, but it was apparently not enough.Try:
which gives
We also fix some compilation warnings.
CC: @seblabbe @jhpalmieri @fchapoton
Component: linear programming
Author: David Coudert
Branch/Commit:
5c6d5fb
Reviewer: Sébastien Labbé
Issue created by migration from https://trac.sagemath.org/ticket/28756
The text was updated successfully, but these errors were encountered: