Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CombinatorialPolyhedron method to Polyhedron objects #28621

Closed
kliem opened this issue Oct 17, 2019 · 12 comments
Closed

Add CombinatorialPolyhedron method to Polyhedron objects #28621

kliem opened this issue Oct 17, 2019 · 12 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.0

Comments

@kliem
Copy link
Contributor

kliem commented Oct 17, 2019

Implement a method that returns the combinatorial polyhedron object of a polyhedron.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: b89610e

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28621
@kliem kliem added this to the sage-9.0 milestone Oct 17, 2019
@kliem
Copy link
Contributor Author

kliem commented Oct 18, 2019

Commit: b89610e

@kliem
Copy link
Contributor Author

kliem commented Oct 18, 2019

New commits:

b89610eadded combinatorial polyhedron as an attribute for polyhedra

@kliem
Copy link
Contributor Author

kliem commented Oct 18, 2019

Changed keywords from none to polytopes, combinatorial polyhedron

@kliem
Copy link
Contributor Author

kliem commented Oct 18, 2019

Branch: public/28621

@jplab

This comment has been minimized.

Sign in to view
@jplab jplab changed the title Add CombinatorialPolyehdron to Polyhedron Add CombinatorialPolyhedron method to Polyhedron objects Oct 18, 2019
@LaisRast
Copy link

comment:3

Looks good.

@LaisRast
Copy link

Reviewer: Laith Rastanawi

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

326602cf_vector of CombinatorialPolyhedron is a vector
dfbe2adMerge branch 'public/28607' of git://trac.sagemath.org/sage into public/28621
ed5518bused CombinatorialPolyhedron to compute f_vector
9bdd005give an error message for polytopes in some cases; removed incorrect example
acd671dnow we get a precice error message for inexact truncated dodecahedron

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2019

Changed commit from b89610e to acd671d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2019

Changed commit from acd671d to b89610e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@vbraun
Copy link
Member

vbraun commented Oct 21, 2019

Changed branch from public/28621 to b89610e

@vbraun vbraun closed this as completed in c072095 Oct 21, 2019
This was referenced May 11, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
4 participants
@vbraun @jplab @kliem @LaisRast