Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 internet doctest failing in oeis.py (Avogadro's) #28127

Closed
seblabbe opened this issue Jul 7, 2019 · 11 comments
Closed

1 internet doctest failing in oeis.py (Avogadro's) #28127

seblabbe opened this issue Jul 7, 2019 · 11 comments

Comments

@seblabbe
Copy link
Contributor

seblabbe commented Jul 7, 2019

With SageMath 8.8, released 2019-06-26, the command

sage -t --long --optional=sage,internet src/sage/databases/oeis.py

gives

sage -t --long src/sage/databases/oeis.py
**********************************************************************
File "src/sage/databases/oeis.py", line 928, in sage.databases.oeis.OEISSequence.natural_object
Failed example:
    av = oeis('A087778') ; av             # optional -- internet
Expected:
    A087778: Decimal expansion of Avogadro's ...
Got:
    A087778: Decimal expansion of experimental Avogadro's constant (in mol^(-1)).
**********************************************************************
1 item had failures:
   1 of  22 in sage.databases.oeis.OEISSequence.natural_object
    5 webbrowser tests not run
    0 tests not run because we ran out of time
    [266 tests, 1 failure, 56.93 s]

We modify the doctest to accommodate this variation in the sequence's description at OEIS.

CC: @slel

Component: doctest coverage

Keywords: oeis

Author: Samuel Lelièvre

Branch/Commit: 4096352

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28127

@seblabbe seblabbe added this to the sage-8.9 milestone Jul 7, 2019
@dimpase
Copy link
Member

dimpase commented Jul 7, 2019

comment:1

well, just change the docstring, as oeis is not cut in stone...

@slel
Copy link
Member

slel commented Jul 9, 2019

Changed keywords from none to oeis

@slel
Copy link
Member

slel commented Jul 9, 2019

Author: Samuel Lelièvre

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jul 9, 2019

@slel
Copy link
Member

slel commented Jul 9, 2019

New commits:

409635228127: Fix oeis avogadro doctest

@slel
Copy link
Member

slel commented Jul 9, 2019

Commit: 4096352

@slel

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jul 9, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 9, 2019

comment:5

looks good to me

@vbraun
Copy link
Member

vbraun commented Jul 10, 2019

Changed branch from u/slelievre/fix-oeis-avogadro-doctest to 4096352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants