Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure SAGE_SPKG_CONFIGURE_GCC is called early #28005

Closed
dimpase opened this issue Jun 17, 2019 · 11 comments
Closed

make sure SAGE_SPKG_CONFIGURE_GCC is called early #28005

dimpase opened this issue Jun 17, 2019 · 11 comments
Labels
c: build: configure p: major / 3 t: bug
Milestone
sage-8.9

Comments

@dimpase
Copy link
Member

dimpase commented Jun 17, 2019

SAGE_SPKG_CONFIGURE_GCC should be called to configure the compiler's options before any place that uses it (in particular c++ is sensitive in this sense, see #27265)

CC: @embray

Component: build: configure

Keywords: days101

Author: Dima Pasechnik

Branch/Commit: d582469

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/28005
@dimpase dimpase added this to the sage-8.9 milestone Jun 17, 2019
@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2019

New commits:

d582469inject SAGE_SPKG_CONFIGURE_GCC into SAGE_SPKG_CONFIGURE macro

@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2019

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2019

Branch: public/config/call_sage_spkg_configure_gcc_early

@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2019

Commit: d582469

@embray
Copy link
Contributor

embray commented Jun 17, 2019

comment:2

Okay, this seems reasonable.

@embray
Copy link
Contributor

embray commented Jun 17, 2019

comment:3

Part of me still has to think there's another way, but without wanting to spend a lot of time on it myself, this does make sense for now to solve the problem. I just tested and am certainly satisfied that it works.

@embray
Copy link
Contributor

embray commented Jun 17, 2019

Reviewer: Erik Bray

@dimpase
Copy link
Member Author

dimpase commented Jun 17, 2019

comment:5

Thanks!

@slel
Copy link
Member

slel commented Jun 19, 2019

comment:6

(Reviewed at Sage Days 101.)

@slel
Copy link
Member

slel commented Jun 19, 2019

Changed keywords from none to days101

@vbraun
Copy link
Member

vbraun commented Jun 28, 2019

Changed branch from public/config/call_sage_spkg_configure_gcc_early to d582469

@vbraun vbraun closed this as completed in 33923d2 Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
4 participants
@embray @vbraun @dimpase @slel