Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration over polyhedron with induced measure #27365

Closed
dkrenn opened this issue Feb 26, 2019 · 41 comments
Closed

integration over polyhedron with induced measure #27365

dkrenn opened this issue Feb 26, 2019 · 41 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 26, 2019

Implement this.

Depends on #27366

CC: @jplab @videlec @kliem

Component: geometry

Keywords: polytope, volume

Author: Daniel Krenn, Matthias Koeppe

Branch/Commit: 3324366

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/27365
@dkrenn dkrenn added this to the sage-8.7 milestone Feb 26, 2019
@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 26, 2019

Dependencies: #27366

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 26, 2019

Branch: u/dkrenn/polyhedron-integrate-induced

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 26, 2019

Commit: 4c67dba

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

4c67dbaTrac #27365: include link to affine_hull

@dkrenn
Copy link
Contributor Author

dkrenn commented Mar 7, 2019

Changed dependencies from #27366 to #27364, #27366

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

09d08d0Trac #27365: doctest boundary case
2d6d181Trac #27365: factor out .integrate_latte method
75da1c2Trac #27365: use new method
fae9549Trac #27365: use AA (instead of SR) for return value if possible
edd78f5Trac #27365: activate one inactive doctest
2460686Trac #27365: rename polynomial --> function
21a6a23Trac #27365: update docstring
8504542Trac #27365: src.sage.interfaces.latte: check for zero polynomial
25e01ffTrac #27365: minor restructure of code (for clearification) in src.sage.interfaces.latte
646a509Trac #27365: cleanup one import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 7, 2019

Changed commit from 4c67dba to 646a509

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

3c09477Trac #27366: fix no-variables-bug-wrong-parent bug
a1664bfMerge branch 't/27366/affine-hull-more' into t/27365/polyhedron-integrate-induced

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 10, 2019

Changed commit from 646a509 to a1664bf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

82ad45bTrac #27366: cache affine hull
3bdea15Trac #27366: reintegrate parametric form and solve dimension bug
bdd92fdMerge branch 't/27366/affine-hull-more' into t/27365/polyhedron-integrate-induced

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2019

Changed commit from a1664bf to bdd92fd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

3a5cfa3Trac #27365: boundary case: integration over polyhedron with only one vertex

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 12, 2019

Changed commit from bdd92fd to 3a5cfa3

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:10

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:11

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
@jplab
Copy link

jplab commented Sep 3, 2019

comment:12

Merge conflict with latest version.

@jplab
Copy link

jplab commented Sep 3, 2019

Changed keywords from none to polytope, volume

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:13

Ticket retargeted after milestone closed

@embray embray removed this from the sage-8.9 milestone Dec 30, 2019
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 13, 2021

comment:18

Merged updated #27366. Untested

New commits:

b407987Merge tag '9.3.rc2' into t/27366/affine-hull-more
d25f7f3Fixup merge
7e0f31daffine_hull -> affine_hull_projection in doctests
2676b0cMerge branch 't/27366/affine-hull-more' into t/27365/polyhedron-integrate-induced

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 13, 2021

Changed commit from 3a5cfa3 to 2676b0c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2021

Changed commit from 2676b0c to a504748

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2661f65Trac #27364: speedup multivariate polynomial construction
0249494Trac #27364: change doctest (due to timing)
ec7977bMerge tag '9.3.rc3' into t/27364/poly-times-vector
a5fd62dsrc/sage/rings/polynomial/multi_polynomial_ring.py: Remove commented-out code
a504748Merge branch 't/27364/poly-times-vector' into t/27365/polyhedron-integrate-induced

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 19, 2021

Changed commit from a504748 to 308cdb2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 19, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

934a33fPolyhedron_base.affine_hull_projection: Error for the empty polyhedron
9629620Polyhedron_base.affine_hull_projection: Fix up use of echelong form
8c24c5cPolyhedron_base.affine_hull_projection: Remove last occurrence of 'parametric_form'
9f5560ainitialize empty matrix after trivial multiplication
f9faa02minimal extension only avoid AA if the base ring is not already AA
397ae3asrc/sage/geometry/polyhedron/base.py: Update copyright according to git blame -w --date=format:%Y src/sage/geometry/polyhedron/base.py | sort -k2
2c1e2bdPolyhedron_base.affine_hull_projection: Return a dataclass instance, not a dictionary
57fd3e1Fixup doctest formatting
48e526fMerge branch 't/27366/affine-hull-more' into t/27365/polyhedron-integrate-induced
308cdb2Polyhedron_base.integrate: Update for new affine_hull_projection output

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 19, 2021

Changed dependencies from #27364, #27366 to #27366

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 19, 2021

Changed author from Daniel Krenn to Daniel Krenn, Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b17aa8cadd another doctest
eee1aadfix section map
23f5de0Merge #27366

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2021

Changed commit from 308cdb2 to 23f5de0

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2021

comment:24

I don't remember why I removed #27364 from the dependencies. The branch is still on top of that ticket's branch. May it can be rebased away from it?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Changed commit from 23f5de0 to 790aec5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

65c3b65Trac #27365: use new method
599ad51Trac #27365: use AA (instead of SR) for return value if possible
57edaddTrac #27365: activate one inactive doctest
1c10622Trac #27365: rename polynomial --> function
b86258bTrac #27365: update docstring
43b68a9Trac #27365: src.sage.interfaces.latte: check for zero polynomial
ddedd05Trac #27365: minor restructure of code (for clearification) in src.sage.interfaces.latte
46bccaaTrac #27365: cleanup one import
8e29094Trac #27365: boundary case: integration over polyhedron with only one vertex
790aec5Polyhedron_base.integrate: Update for new affine_hull_projection output

@mkoeppe
Copy link
Contributor

mkoeppe commented May 25, 2021

comment:26

Rebased away from #27364

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

a25c0efsrc/sage/geometry/polyhedron/base.py: Add some # optional - latte_int
3324366Polyhedron_base._integrate_latte_: Fix error message

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Changed commit from 790aec5 to 3324366

@mkoeppe
Copy link
Contributor

mkoeppe commented May 25, 2021

comment:28

Ready for review

@kliem
Copy link
Contributor

kliem commented May 28, 2021

comment:29

LGTM.

@kliem
Copy link
Contributor

kliem commented May 28, 2021

Reviewer: Jonathan Kliem

@vbraun
Copy link
Member

vbraun commented Jun 7, 2021

Changed branch from u/mkoeppe/polyhedron-integrate-induced to 3324366

@vbraun vbraun closed this as completed in d1c6188 Jun 7, 2021
@jplab jplab mentioned this issue Aug 9, 2020
Open
This was referenced Jan 29, 2023
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
6 participants
@embray @vbraun @jplab @mkoeppe @dkrenn @kliem