Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron/base: very minor "fixes" #27329

Closed
dkrenn opened this issue Feb 20, 2019 · 7 comments
Closed

Polyhedron/base: very minor "fixes" #27329

dkrenn opened this issue Feb 20, 2019 · 7 comments
Labels
c: geometry good first issue p: trivial / 5 t: bug
Milestone
sage-8.7

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 20, 2019

This ticket contains some collected very minor "fixes" (not even sure if they would be called that way) after going through the docs/file.

Component: geometry

Keywords: easy review

Author: Daniel Krenn

Branch/Commit: 74470e2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27329
@dkrenn dkrenn added this to the sage-8.7 milestone Feb 20, 2019
@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2019

Branch: u/dkrenn/minor-polyhedra

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2019

Changed keywords from none to easy review

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2019

Commit: 74470e2

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 20, 2019

New commits:

1ca3e2cTrac #27329: actually use **kwds as promised in docs
4efdb48Trac #27329: insert 3 whitespaces (PEP8)
74470e2Trac #27329: insert an additional doctest enhancing the readability of

@tscrim
Copy link
Collaborator

tscrim commented Feb 20, 2019

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 20, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Feb 25, 2019

Changed branch from u/dkrenn/minor-polyhedra to 74470e2

@vbraun vbraun closed this as completed in 7422882 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry good first issue p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @dkrenn