Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doctest in graph_latex #27249

Closed
dcoudert opened this issue Feb 10, 2019 · 7 comments
Closed

fix doctest in graph_latex #27249

dcoudert opened this issue Feb 10, 2019 · 7 comments
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-8.7

Comments

@dcoudert
Copy link
Contributor

Reported on https://groups.google.com/forum/#!topic/sage-release/0QvdNonpGEg.
Doctest failing in dot2tex_picture with 8.7.beta3 and optional package dot2tex.

CC: @seblabbe

Component: graph theory

Author: David Coudert

Branch/Commit: f0eb317

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/27249
@dcoudert dcoudert added this to the sage-8.7 milestone Feb 10, 2019
@dcoudert
Copy link
Contributor Author

Commit: f0eb317

@dcoudert
Copy link
Contributor Author

New commits:

f0eb317trac #27249: fix doctest

@dcoudert
Copy link
Contributor Author

Branch: public/27249_dot2tex_picture

@seblabbe
Copy link
Contributor

comment:2

It fixes the reported issue.

I was wondering if this was related to bliss? Anyhow, I have bliss installed and with bliss the issue is fixed.

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@dcoudert
Copy link
Contributor Author

comment:4

It's related to changes in the ordering of vertices/edges: we don't sort unless mandatory. Typically, for plotting there is no need for sorting the vertices/edges.

Also I forgot to re-install dot2tex after my last dist-clean...

@vbraun
Copy link
Member

vbraun commented Feb 13, 2019

Changed branch from public/27249_dot2tex_picture to f0eb317

@vbraun vbraun closed this as completed in 714748d Feb 13, 2019
@seblabbe seblabbe mentioned this issue Oct 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @seblabbe @dcoudert