5 internet doctests failing in findstat.py

[seblabbe]

On Ubuntu 16.04, running sage-8.5.beta1, the command

sage -t --long --optional=sage,internet src/sage/databases/findstat.py

gives

...
3 items had failures:
   3 of  16 in sage.databases.findstat
   1 of   4 in sage.databases.findstat.FindStatStatistic.__repr__
   1 of   9 in sage.databases.findstat.FindStatStatistic._find_by_values
    [247 tests, 5 failures, 107.27 s]
----------------------------------------------------------------------
sage -t --long src/sage/databases/findstat.py  # 5 doctests failed
----------------------------------------------------------------------

Full failure log is long and is pasted here: https://framabin.org/p/?b9dacda8324c7295#71YTYesLKEKBCNg1LtnDUhKkWDrcm+xiZGDI9a8bjfg=

CC: @vinklein

Component: doctest coverage

Author: Martin Rubey

Branch: 6079bf0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26997

[mantepse]

comment:1

The problem is that the semantics of FancyTuple changed, and I think in a bad way:

sage: FancyTuple([(1,2,3),(4,5,6)])
0: 0: 1
1: 2
2: 3
1: 0: 4
1: 5
2: 6

sage: FancyTuple([[1,2,3],(4,5,6)])
0: [1, 2, 3]
1: 0: 4
1: 5
2: 6

I think this comes from #26704 but I didn't check.

[mantepse]

Branch: u/mantepse/5_internet_doctests_failing_in_findstat_py

[mantepse]

comment:3

easy fix, according to the specification of FancyTuple.__getitem__.

---

New commits:

6079bf0

fix `__getitem__` of FancyTuple to preserve tuple-items

[mantepse]

Commit: 6079bf0

[mantepse]

Author: Martin Rubey

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:6

seems to be ok on python3

[embray]

comment:7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

[vbraun]

Changed branch from u/mantepse/5_internet_doctests_failing_in_findstat_py to 6079bf0

[seblabbe]

comment:9

5 new other failing internet doctests in findstat at #27838

[seblabbe]

Changed commit from 6079bf0 to none