-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have libgap permutation to sage use permutation instead of permutation group element #25609
Comments
Dependencies: #25477 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
This is not really depending on #25477, I think. But anyways, this is only a very small change... |
Reviewer: Travis Scrimshaw |
comment:8
LGTM (but I agree that #25477 should not really be a dependency). |
comment:9
See patchbot |
comment:10
This fixes the errors on the patchbot (the polyhedron one was fixed in #25477 and I cannot reproduce it now here). New commits:
|
comment:11
Green patchbot (morally). |
comment:12
Green patchbot (still). |
comment:13
Can I put it to positive review? |
comment:14
Yes. In fact, I needed someone else to review my changes. :) |
Changed branch from u/tscrim/libgap_to_sage_permutation_construction-25609 to |
Changed commit from |
This is a side improvement of #25477, as seen there in comment 62 (please properly link if possible):
So creating a new permutation is much faster than creating a permutation group element. If we know which permutation group we live in, there is even a faster way:
Depends on #25477
CC: @tscrim @dimpase
Component: group theory
Keywords: permutation group, libgap
Author: Christian Stump
Branch:
2396cf0
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/25609
The text was updated successfully, but these errors were encountered: