Algebraic polyhedra with Normaliz / e-antic #25097

mkoeppe · 2018-04-03T23:31:05Z

Implements polyhedra over embedded algebraic number fields.

Preliminary setup within sage: install e-antic, upgrade normaliz/pynormaliz (see upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package e-antic #27682)
the input is allowed to come from various fields, which will be coerced to a number field first via number_field_elements_from_algebraics should create embedded number field elements #20181:

        sage: x = polygen(ZZ); P = Polyhedron(vertices=[[sqrt(2)], [AA.polynomial_root(x^3-2, RIF(0,3))]], backend='normaliz')

See doctests in src/sage/geometry/polyhedron/backend_normaliz.py and src/sage/geometry/polyhedron/library.py
For debugging help, we can write out Normaliz input files and PyNormaliz function calls as a side effect by passing verbose=True.

Depends on #25091
Depends on #27731
Depends on #27965

CC: @w-bruns @videlec @jplab @sebasguts @sagetrac-tmonteil @mo271

Component: geometry

Keywords: IMA-PolyGeom

Author: Matthias Koeppe

Branch/Commit: f94bf37

Reviewer: Vincent Delecroix, Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/25097

The text was updated successfully, but these errors were encountered:

videlec · 2018-04-04T08:56:18Z

comment:1

prerequisite: package antic (that has no release yet).

mkoeppe · 2018-04-04T19:22:29Z

Branch: u/mkoeppe/qnormaliz-algebraic

mkoeppe · 2018-04-04T19:30:23Z

Changed branch from u/mkoeppe/qnormaliz-algebraic to public/25097/qnormaliz-algebraic

mkoeppe · 2018-04-04T19:33:00Z

Dependencies: #25090

mkoeppe · 2018-04-04T19:33:00Z

Last 10 new commits:

`117e428`	`Upgrade normaliz to 3.5.3`
`7057ef4`	`Merge branch to get docstring adaptation`
`b6ae686`	`Merge branch 'develop' of git://trac.sagemath.org/sage into t/25090/pynormaliz2`
`eaedcc2`	`Update PyNormaliz to 1.14`
`4dbdc7d`	`Updated the Cone calls format`
`1dcef4c`	`_init_from_normaliz_data: New, use it in _init_from_*representation`
`fcd8101`	`Updated pynormaliz to 1.15`
`19d8539`	`Polyhedron_normaliz: In verbose mode, write out normaliz format files`
`4cfcd14`	`_normaliz_format: Fix last change`
`ea7a6b8`	`Polyhedron_normaliz: Prepare classes for work over field extensions`

mkoeppe · 2018-04-04T19:33:00Z

Commit: ea7a6b8

mkoeppe · 2018-04-04T20:02:45Z

comment:8

Could someone who has worked on / has opinions on the Polyhedron constructor code help here?

What should we do for polyhedra over AA such as the following:

sage: P = polytopes.regular_polygon(3)
sage: P.base_ring()
Algebraic Real Field

If backend=normaliz is requested, should we cast to the appropriate number field via #20181? Or should it be an error?

jplab · 2018-04-05T23:09:15Z

Changed dependencies from #25090 to #25090, #20181

jplab · 2018-04-05T23:11:08Z

comment:14

What should we do for polyhedra over AA such as the following:
sage: P = polytopes.regular_polygon(3)
sage: P.base_ring()
Algebraic Real Field
If backend=normaliz is requested, should we cast to the appropriate number field via #20181? Or should it be an error?

I would say the cleanest thing to do once #20181 is done will be to use it! This probably will also simplify the constructor for field.

sagetrac-git · 2018-04-06T21:21:33Z

Changed commit from ea7a6b8 to 13d27d4

sagetrac-git · 2018-04-06T21:21:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`26dc3e4`	`Added option for embedded NumberField`
`db778ee`	`Made it possible to deal with complex number fields`
`13d27d4`	`Merge remote-tracking branch 'trac/public/algnum_to_numberfield' into t/25097/public/25097/qnormaliz-algebraic`

sagetrac-git · 2018-04-06T21:50:31Z

Changed commit from 13d27d4 to 5af97b3

sagetrac-git · 2018-04-06T21:50:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5af97b3`	`Polyhedron_normaliz: Separate constructors for QQ, general fields (no cnaceling)`

mkoeppe · 2018-04-08T18:10:22Z

comment:18

I put some preliminary code in to do the coercion to number fields inside the Polyhedron_normaliz implementation, using number_field_elements_from_algebraics.

sagetrac-git · 2018-04-08T18:10:38Z

Changed commit from 5af97b3 to d2aee02

sagetrac-git · 2018-04-08T18:10:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0f325c0`	`Polyhedron: Allow SR input for normaliz`
`aa22d44`	`Polyhedron_normaliz._nmz_result: New, use it instead of directly calling PyNormaliz.NmzResult`
`7e4f1ac`	`Polyhedron_normaliz: _init_from_Vrepresentation: Coerce to numberfield`
`0ba9f6b`	`Polyhedron_normaliz: Pass number field to QNormaliz`
`d2aee02`	`_init_from_normaliz_data: Separate implementations for QNormaliz, Normaliz`

sagetrac-git · 2018-04-08T22:54:51Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2bb8958`	`_number_field_elements_from_algebraics_list_of_lists: New, refactor Polyhedron_normaliz using it`
`a9045bf`	`Added tests and made them pass`
`09df646`	`Merge remote-tracking branch 'trac/public/algnum_to_numberfield' into t/25097/public/25097/qnormaliz-algebraic`
`01d7cfc`	`lists of lists of lists of algebraic numbers, actually`

sagetrac-git · 2018-04-08T22:54:51Z

Changed commit from d2aee02 to 01d7cfc

sagetrac-git · 2018-04-09T03:10:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d7ecb03`	`Temporary build scripts for normaliz, pynormaliz, pyqnormaliz`

embray · 2019-06-14T14:50:27Z

comment:131

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

sagetrac-git · 2019-06-19T21:54:12Z

Changed commit from ca71cc2 to 4258704

sagetrac-git · 2019-06-19T21:54:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`28b8dbd`	`Merge tag '8.8.rc1' into t/25097/public/normaliz-3.7.0-algebraic`
`6fcdf05`	`trac 27965: py3 fix in geometry/polyhedron/library.py`
`3d46bb2`	`Merge branch 't/27965/27965' into t/25097/public/normaliz-3.7.0-algebraic`
`4258704`	`Fix doctests for changed embedded numberfield repr`

jplab · 2019-06-21T09:57:18Z

comment:134

Looks good to me now. I would say this is ready and I would put it as positive review, with Vincent also as a reviewer too.

@Vincent: Let us know if you agree. It would be good to know if there are last things to be aware of.

jplab · 2019-06-21T09:57:18Z

Changed reviewer from Jean-Philippe Labbé to Vincent Delecroix, Jean-Philippe Labbé

jplab · 2019-07-05T07:21:09Z

comment:135

ping!

Any last comments Vincent?

fchapoton · 2019-07-07T09:40:19Z

comment:136

doctest failure in /library with py3

sagetrac-git · 2019-07-08T19:38:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`23b1cbe`	`Merge tag '8.9.beta1' into t/25097/public/normaliz-3.7.0-algebraic`
`f94bf37`	`snub_dodecahedron: Disable doctests for broken floating point computation`

sagetrac-git · 2019-07-08T19:38:12Z

Changed commit from 4258704 to f94bf37

fchapoton · 2019-07-11T13:55:34Z

comment:139

The last changes looks reasonable to me.

jplab · 2019-07-16T16:02:07Z

comment:140

It looks good to me too. I set it to positive review.

Just a FYI: if there are any other comments, next week is the Sage days in Bonn and vdelecroix and me are going to be available to work on follow-ups if need be.

vbraun · 2019-07-18T21:02:39Z

Changed branch from public/25097/qnormaliz-algebraic to f94bf37

mkoeppe added this to the sage-8.2 milestone Apr 3, 2018

mkoeppe added c: geometry labels Apr 3, 2018

This comment has been minimized.

Sign in to view

embray modified the milestones: sage-8.8, sage-8.9 Jun 14, 2019

mkoeppe added s: needs review and removed s: needs work labels Jun 19, 2019

fchapoton added s: needs work and removed s: needs review labels Jul 7, 2019

mkoeppe added s: needs review and removed s: needs work labels Jul 8, 2019

jplab added s: positive review and removed s: needs review labels Jul 16, 2019

vbraun removed the s: positive review label Jul 18, 2019

vbraun closed this as completed in 16aca5f Jul 18, 2019

videlec mentioned this issue Apr 29, 2019

upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package e-antic #27682

Closed

This was referenced Jan 7, 2023

Non-rational polytopes: Examples and constructor #27728

Open

Bug in intersection of polyhedron (backend normaliz with algebraic numbers) #27737

Closed

Generalized Permutohedra and type H4 4-uniform polytopes #27760

Closed

kliem mentioned this issue Aug 30, 2019

Preserve backend for polytopal constructions #27926

Closed

jplab mentioned this issue Jan 7, 2023

Thematic Tutorial on algebraic polytopes in Sage using Normaliz #28230

Open

Algebraic polyhedra with Normaliz / e-antic #25097

Algebraic polyhedra with Normaliz / e-antic #25097

Comments

mkoeppe commented Apr 3, 2018

videlec commented Apr 4, 2018

mkoeppe commented Apr 4, 2018

mkoeppe commented Apr 4, 2018

mkoeppe commented Apr 4, 2018

mkoeppe commented Apr 4, 2018

This comment has been minimized.

mkoeppe commented Apr 4, 2018

This comment has been minimized.

mkoeppe commented Apr 4, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jplab commented Apr 5, 2018

jplab commented Apr 5, 2018

sagetrac-git mannequin commented Apr 6, 2018

sagetrac-git mannequin commented Apr 6, 2018

sagetrac-git mannequin commented Apr 6, 2018

sagetrac-git mannequin commented Apr 6, 2018

This comment has been minimized.

mkoeppe commented Apr 8, 2018

sagetrac-git mannequin commented Apr 8, 2018

sagetrac-git mannequin commented Apr 8, 2018

sagetrac-git mannequin commented Apr 8, 2018

sagetrac-git mannequin commented Apr 8, 2018

sagetrac-git mannequin commented Apr 9, 2018

embray commented Jun 14, 2019

sagetrac-git mannequin commented Jun 19, 2019

sagetrac-git mannequin commented Jun 19, 2019

jplab commented Jun 21, 2019

jplab commented Jun 21, 2019

jplab commented Jul 5, 2019

fchapoton commented Jul 7, 2019

sagetrac-git mannequin commented Jul 8, 2019

sagetrac-git mannequin commented Jul 8, 2019

fchapoton commented Jul 11, 2019

jplab commented Jul 16, 2019

vbraun commented Jul 18, 2019