Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cdefs.pxi and stdsage.pxi #23855

Closed
jdemeyer opened this issue Sep 14, 2017 · 10 comments
Closed

Deprecate cdefs.pxi and stdsage.pxi #23855

jdemeyer opened this issue Sep 14, 2017 · 10 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

Cython upstream considers .pxi files to be semi-deprecated, so we should deprecate cdefs.pxi and friends, which are no longer used.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 29b25b4

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/23855
@jdemeyer jdemeyer added this to the sage-8.1 milestone Sep 14, 2017
@jdemeyer jdemeyer changed the title Deprecate various .pxi files Deprecate cdefs.pxi and stdsage.pxi Sep 14, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/deprecate_various__pxi_files

@jdemeyer
Copy link
Author

New commits:

7d4891bDeprecate cdefs.pxi and stdsage.pxi

@jdemeyer
Copy link
Author

Commit: 7d4891b

@videlec
Copy link
Contributor

videlec commented Sep 15, 2017

comment:4

Would it be possible to doctest that the deprecation is actually visible?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

29b25b4Deprecate cdefs.pxi and stdsage.pxi

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2017

Changed commit from 7d4891b to 29b25b4

@jdemeyer
Copy link
Author

comment:6

Done

@videlec
Copy link
Contributor

videlec commented Sep 15, 2017

comment:7

Better. Thanks!

@videlec
Copy link
Contributor

videlec commented Sep 15, 2017

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Sep 18, 2017

Changed branch from u/jdemeyer/deprecate_various__pxi_files to 29b25b4

@vbraun vbraun closed this as completed in 79ce4b3 Sep 18, 2017
@jdemeyer jdemeyer mentioned this issue Jan 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec