(experimental) Compile Cython code with binding=True

[jdemeyer]

When using the Cython compiler directive binding=True, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in inspect support.

We find several Cython bugs regarding binding=True:

• binding=True in .pxd generates global too late cython/cython#1658 (not an issue for Sage)
• Do not apply decorators twice cython/cython#1724 (see Add Cython patches to fix various issues with binding=True #23155)
• Don't use __Pyx_PyObject_CallMethO on cyfunctions cython/cython#1728 (see Add Cython patches to fix various issues with binding=True #23155)

Depends on #25842
Depends on #25845
Depends on #25848

Upstream: Reported upstream. No feedback yet.

CC: @kwankyu

Component: cython

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/22747 @ d962040

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/22747

[jdemeyer]

Branch: u/jdemeyer/ticket/22747

[sagetrac-git]

Commit: 2b70327

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2b70327

Compile Cython code with binding=True

[jdemeyer]

Changed dependencies from #21682 to #21843

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b56b4be	Include Cython directives in .cython_version file
547397b	Compile Cython code with binding=True

[sagetrac-git]

Changed commit from 2b70327 to 547397b

[jdemeyer]

Upstream: Reported upstream. No feedback yet.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ee13351

Compile Cython code with binding=True

[sagetrac-git]

Changed commit from 547397b to ee13351

[jdemeyer]

Changed dependencies from #21843 to #21843, #22852

[sagetrac-git]

Changed commit from ee13351 to 93250a2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

841676d	Define functions before calling them
8994ace	Merge commit '841676d4931c9f59019b2b6b82afbbe7df222c10' into t/22747/ticket/22747
93250a2	Compile Cython code with binding=True

[sagetrac-git]

Changed commit from 93250a2 to 1e78314

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1e78314

Compile Cython code with binding=True

[jdemeyer]

Changed dependencies from #21843, #22852 to none

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a57b913	QuotientRing_nc.ideal(): use super() instead of CommutativeRing
e62cc3a	Compile Cython code with binding=True

[sagetrac-git]

Changed commit from 1e78314 to e62cc3a

[jdemeyer]

Dependencies: #23103

[sagetrac-git]

Changed commit from e62cc3a to 680f4a7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

256bf19	Move richcmp stuff to new file richcmp.pyx
7629851	Merge tag '8.0.beta9' into t/23103/move_richcmp_stuff_to_new_file
031761f	Fix two more imports
f159d41	Add Cython patch to fix decorators with binding=True
680f4a7	Compile Cython code with binding=True

[jdemeyer]

Changed dependencies from #23103 to #23103, #23122

[jdemeyer]

Changed dependencies from #23103, #23122, #23155, #15947, #23159 to none

[sagetrac-git]

Changed commit from dba0dd6 to 0f70aed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f1debe3	Upgrade to Cython 0.28.4
ee4c6c4	Compile Cython code with binding=True
aa3513f	Sage library fixes for binding=True
0f70aed	Try to fix Set_PythonType

[sagetrac-git]

Changed commit from 0f70aed to 60007d5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6310172	Fix a cyclic import involving interval fields
60007d5	Move Set_PythonType to a new file

[sagetrac-git]

Changed commit from 60007d5 to 13068eb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

13068eb

Move Set_PythonType to a new file

[jdemeyer]

Dependencies: #25845

[sagetrac-git]

Changed commit from 13068eb to ddb7cc8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7e7daef	Move Set_PythonType to a new file
48f170f	Compile Cython code with binding=True
46a7887	Sage library fixes for binding=True
ddb7cc8	Fix a cyclic import involving interval fields

[sagetrac-git]

Changed commit from ddb7cc8 to 5282f12

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8756c40	Some preparations for binding=True
5282f12	Sage library fixes for binding=True

[sagetrac-git]

Changed commit from 5282f12 to d962040

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

742e1c9	Some preparations for binding=True
c5a8bd3	Compile Cython code with binding=True
d962040	Sage library fixes for binding=True

[jdemeyer]

Changed dependencies from #25845 to #25842, #25845, #25848

[mkoeppe]

comment:36

We can close this ticket in favor of #26254.

The only commit from the branch here that is useful is sagemath/sagetrac-mirror@d962040 -- not really "Sage library fixes" but just some updates of doctest outputs.

[orlitzky]

comment:37

Ok, #26254 looks much further along.

[orlitzky]

Reviewer: Michael Orlitzky