Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate python.pxi #20158

Closed
jdemeyer opened this issue Mar 4, 2016 · 8 comments
Closed

Deprecate python.pxi #20158

jdemeyer opened this issue Mar 4, 2016 · 8 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

jdemeyer commented Mar 4, 2016

Continue the cleanup of unneeded .pxi files.

CC: @fchapoton

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 7777e4e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20158
@jdemeyer jdemeyer added this to the sage-7.1 milestone Mar 4, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Mar 4, 2016

Branch: u/jdemeyer/deprecate_python_pxi

@jdemeyer
Copy link
Author

jdemeyer commented Mar 4, 2016

Commit: 7777e4e

@jdemeyer
Copy link
Author

jdemeyer commented Mar 4, 2016

New commits:

7777e4eDeprecate python.pxi

@jdemeyer
Copy link
Author

jdemeyer commented Mar 4, 2016

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor

comment:4

Ok, this looks good (just meaning I am not able to see any issue), and the bots see no problem.

I am giving a positive review.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Mar 6, 2016

Changed branch from u/jdemeyer/deprecate_python_pxi to 7777e4e

@vbraun vbraun closed this as completed in 16af6fa Mar 6, 2016
@jdemeyer jdemeyer mentioned this issue Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton