Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate gsl.pxi and gsl/callback.pyx #20135

Closed
jdemeyer opened this issue Feb 29, 2016 · 11 comments
Closed

Deprecate gsl.pxi and gsl/callback.pyx #20135

jdemeyer opened this issue Feb 29, 2016 · 11 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

These .pxi files should not be used, it's considered better Cython style to use .pxd files.

I'm also deprecating src/sage/gsl/callback.pyx, a very small module which is undocumented and usused.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 7f9272b

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20135
@jdemeyer jdemeyer added this to the sage-7.1 milestone Feb 29, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/deprecate_gsl_pxi

@jdemeyer
Copy link
Author

New commits:

3a58a17Deprecate gsl.pxi and gsl/callback.pyx

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Commit: 3a58a17

@jdemeyer jdemeyer changed the title Deprecate gsl.pxi Deprecate gsl.pxi and gsl/callback.pyx Feb 29, 2016
@fchapoton
Copy link
Contributor

comment:3

ok, looks good to me. And the bots are happy.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Mar 1, 2016

comment:4

Merge conflict, wait for next beta..

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2016

Changed commit from 3a58a17 to 7f9272b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

7f9272bMerge tag '7.1.beta6' into t/20135/deprecate_gsl_pxi

@jdemeyer
Copy link
Author

jdemeyer commented Mar 4, 2016

comment:6

Fixed trivial merge conflict

@vbraun
Copy link
Member

vbraun commented Mar 5, 2016

Changed branch from u/jdemeyer/deprecate_gsl_pxi to 7f9272b

@vbraun vbraun closed this as completed in 968c8f1 Mar 5, 2016
@jdemeyer jdemeyer mentioned this issue Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton