Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all exceptions in ._sage_doc_ attribute access #19671

Closed
jdemeyer opened this issue Dec 5, 2015 · 13 comments
Closed

Ignore all exceptions in ._sage_doc_ attribute access #19671

jdemeyer opened this issue Dec 5, 2015 · 13 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 5, 2015

The current docbuilder cannot cope with obj._sage_doc_ accesses raising RuntimeError for example.

Component: documentation

Author: Jeroen Demeyer

Branch/Commit: c9980ee

Reviewer: François Bissey, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/19671

@jdemeyer jdemeyer added this to the sage-6.10 milestone Dec 5, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title FIx docbuild for sagenb upgrade Ignore all exceptions in ._sage_obj_ attribute access Dec 5, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Dec 5, 2015

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c9980eeAllow all exceptions in obj._sage_obj_

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 5, 2015

Commit: c9980ee

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Ignore all exceptions in ._sage_obj_ attribute access Ignore all exceptions in ._sage_doc_ attribute access Dec 5, 2015
@kcrisman
Copy link
Member

kcrisman commented Dec 5, 2015

comment:6

Ah, I see now why Sloane.

As I said in #19616, it does build doc successfully with these changes, though I don't have my Sage install convenient to actually try the tests. Anyone else could review that.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 5, 2015

comment:7

Replying to @kcrisman:

try the tests.

You mean doctests or something else? The doctests pass.

@kcrisman
Copy link
Member

kcrisman commented Dec 5, 2015

comment:8

I mean doctests, but I didn't know if one was allowed to use the patchbot to confirm this or test it oneself. I usually try them 'by hand' and a few other things, and I won't be able to do more with that until at least Monday, probably Wednesday. If you think this is sufficient though then I certainly trust patchbot + you and you can set it to positive review.

@kiwifb
Copy link
Member

kiwifb commented Dec 10, 2015

comment:9

I think it is sufficient.

@kiwifb
Copy link
Member

kiwifb commented Dec 10, 2015

Reviewer: François Bissey

@kcrisman
Copy link
Member

Changed reviewer from François Bissey to François Bissey, Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:10

Thanks François.

@vbraun
Copy link
Member

vbraun commented Dec 22, 2015

Changed branch from u/jdemeyer/fix_docbuild_for_sagenb_upgrade to c9980ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants