-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore all exceptions in ._sage_doc_ attribute access #19671
Comments
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:6
Ah, I see now why Sloane. As I said in #19616, it does build doc successfully with these changes, though I don't have my Sage install convenient to actually try the tests. Anyone else could review that. |
comment:7
Replying to @kcrisman:
You mean doctests or something else? The doctests pass. |
comment:8
I mean doctests, but I didn't know if one was allowed to use the patchbot to confirm this or test it oneself. I usually try them 'by hand' and a few other things, and I won't be able to do more with that until at least Monday, probably Wednesday. If you think this is sufficient though then I certainly trust patchbot + you and you can set it to positive review. |
comment:9
I think it is sufficient. |
Reviewer: François Bissey |
Changed reviewer from François Bissey to François Bissey, Karl-Dieter Crisman |
comment:10
Thanks François. |
Changed branch from u/jdemeyer/fix_docbuild_for_sagenb_upgrade to |
The current docbuilder cannot cope with
obj._sage_doc_
accesses raisingRuntimeError
for example.Component: documentation
Author: Jeroen Demeyer
Branch/Commit:
c9980ee
Reviewer: François Bissey, Karl-Dieter Crisman
Issue created by migration from https://trac.sagemath.org/ticket/19671
The text was updated successfully, but these errors were encountered: