Parent/Element relation for ChainComplex/Chain #15161
Milestone
Comments
|
Author: Volker Braun |
|
Branch: u/vbraun/chain_complex_parents |
|
Commit: |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:4
comment:2 is a minor screwup of the scripts, only the first commit should have been listed... In any case, all tests pass for me and I did what I wanted to do on this ticket. Ready for review... |
This comment has been minimized.
This comment has been minimized.
|
comment:5
I don't understand the example |
|
comment:6
Here, element = chain, i.e. an element of the direct sum of the Since it is useful to see the coordinate expression of a chain that is supported only in a single degree (e.g. homology generators) they are printed differently: |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:8
I've been busy with various departmental duties for the past month, but I'd like to start reviewing this soon. I don't know how to review git tickets, though, and the directions I've found seem to be contradictory (if I download Sage from git and type Furthermore, I don't know how to look at the relevant changes easily. Do I really need to look at half a dozen different changesets, or is there a unified view somewhere? On this ticket, the "branch" field doesn't seem to be active, but on a ticket like #15202, if I click on "Commits" I get a pretty diagram, and then from there if I click on "View changes", I get "504 Gateway Time-out. The server didn't respond in time." I guess I'm supposed to click on the branch name instead? |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:10
Starting this week, using git should be relatively simple. If you download the current master from github (say) then installation should just work. See http://trac.sagemath.org/wiki/QuickStartSageGit The developer scripts should also work as in http://sagemath.github.io/git-developer-guide/walk_through.html: gets you the source code. Then make/test as usual. To see all source code changes relative to the master branch, use
|
|
comment:11
On a quick reading of chain_complex.py:
I'll keep working on this. |
|
Attachment: trac_15161_docstrings.patch.gz fixes white space and other small issues in some docstrings |
|
comment:12
In cell_complex.py, just about everything looks good, except for one misformatted docstring (plus the missing word "as"): diff --git a/src/sage/homology/cell_complex.py b/src/sage/homology/cell_complex.py
index d736837..02d53fa 100644
--- a/src/sage/homology/cell_complex.py
+++ b/src/sage/homology/cell_complex.py
@@ -20,7 +20,8 @@ by developers producing new classes, not casual users.
the :meth:`~GenericCellComplex.homology` method get passed on to
the :meth:`~GenericCellComplex.chain_complex` method and also to
the constructor for chain complexes in
- :class:`sage.homology.chain_complex.ChainComplex_class <ChainComplex>`, as well its
+ :class:`ChainComplex <sage.homology.chain_complex.ChainComplex_class>`,
+ as well as its
associated
:meth:`~sage.homology.chain_complex.ChainComplex_class.homology` method.
This means that those keywords should have consistent meaning inAlso, the newly created files ( |
|
Reviewer: John Palmieri, Travis Scrimshaw |
|
comment:13
Hey Volker and John, I've worked in all of John's documentation changes and made a few of my own (plus rebased to the latest version of Sage). I don't think we should deprecate Best, Travis New commits:
|
|
Changed branch from u/vbraun/chain_complex_parents to public/homology/chain_complex_parents-15161 |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:15
I'd also like this change: diff --git a/src/doc/en/reference/homology/index.rst b/src/doc/en/reference/homology/index
index 82c2f33..147cd8c 100644
--- a/src/doc/en/reference/homology/index.rst
+++ b/src/doc/en/reference/homology/index.rst
@@ -21,6 +21,8 @@ cell complexes.
sage/homology/delta_complex
sage/homology/cubical_complex
sage/homology/cell_complex
+ sage/homology/homology_group
+ sage/homology/matrix_utils
sage/interfaces/chomp
.. include:: ../footer.txt |
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
|
comment:17
Ack, I completely forgot about that. Done. |
|
Changed author from Volker Braun to Volker Braun, Travis Scrimshaw |
|
comment:18
Everything looks good to me. |
|
comment:19
I don't think what I did warrants author credits (especially since most of what I changes was in John's review patch |
|
Changed author from Volker Braun, Travis Scrimshaw to Volker Braun |
|
comment:22
See #15730 for a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nothing in
sage.homologymakes use of the Parent/Element framework. But it would be nice to be able to work with chains and use normal syntax for addition and multiplication by scalars. The aim of this ticket is to adapt chain complexes. The analogous project for cell complexes will be left for a future ticket.Next to code cleanup, I also added ascii art support:
CC: @jhpalmieri @tscrim
Component: algebraic topology
Author: Volker Braun
Branch/Commit: public/homology/chain_complex_parents-15161 @
e955febReviewer: John Palmieri, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/15161
The text was updated successfully, but these errors were encountered: