Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython sometimes embeds wrong file names in docstrings #14634

Closed
vbraun opened this issue May 23, 2013 · 6 comments
Closed

Cython sometimes embeds wrong file names in docstrings #14634

vbraun opened this issue May 23, 2013 · 6 comments
Assignees
@jdemeyer
Labels
c: cython p: major / 3 t: bug

Comments

@vbraun
Copy link
Member

vbraun commented May 23, 2013

Cython's Nodes.relative_position makes file names relative by stripping off the first len(os.path.abspath(os.getcwd())) characters. This is totally wrong if the file is from the include search path and not relative to cwd

Upstream bug report: http://trac.cython.org/cython_trac/ticket/817

The first patch makes the last two includes in Sage absolute, which triggers the bug.

Apply:

Depends on #12728

Upstream: Reported upstream. No feedback yet.

Component: cython

Issue created by migration from https://trac.sagemath.org/ticket/14634
@vbraun vbraun added this to the sage-5.11 milestone May 23, 2013
@vbraun

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member Author

vbraun commented May 23, 2013

Upstream: Reported upstream. No feedback yet.

@vbraun
Copy link
Member Author

vbraun commented May 23, 2013

Attachment: trac_14634_fix_includes.patch.gz

Initial patch

@vbraun
Copy link
Member Author

vbraun commented May 23, 2013

Dependencies: #12728

@vbraun

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 8, 2023

Closing as outdated

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdemeyer jdemeyer

Labels
c: cython p: major / 3 t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @mkoeppe