Remove CombinatorialClass from skew*

[tscrim]

Removing CombinatorialClass from combinat/skew_partition.py and combinat/skew_tableau.py.

Part of #12913.

---

Apply: attachment: trac_14101-remove_cc_skew-ts.patch

Depends on #7983
Depends on #14772
Depends on #13589
Depends on #14907
Depends on #10630

CC: @sagetrac-sage-combinat @zabrocki @nthiery @sagetrac-alubovsky

Component: combinatorics

Keywords: days45, days49

Author: Travis Scrimshaw, Arthur Lubovsky

Reviewer: Travis Scrimshaw, Arthur Lubovsky

Merged: sage-5.12.beta4

Issue created by migration from https://trac.sagemath.org/ticket/14101

[tscrim]

Changed keywords from sage-combinat, days45 to days45

[tscrim]

Reviewer: Travis Scrimshaw, Arthur Lubovsky

[tscrim]

Changed keywords from days45 to days45, days49

[tscrim]

Changed author from Travis Scrimshaw to Travis Scrimshaw, Arthur Lubovsky

[tscrim]

comment:2

The dependency on #14772 is some fuzz due to editing of cython files in symmetrica.

[tscrim]

Dependencies: #14772

[tscrim]

comment:3

There is a minor dependency in integer_vector_weighted.py from #13589.

[tscrim]

Changed dependencies from #14772 to #14772 #13589

[tscrim]

comment:4

Removed fuzz caused by #14907 (I think).

[tscrim]

Changed dependencies from #14772 #13589 to #14772 #13589 #14907

[tscrim]

comment:5

I also fixed the error with SkewTableau.to_chain().

[tscrim]

comment:7

Fixed corner case of to_chain(). Thanks for catching that Mike.

[darijgr]

Attachment: trac_14772-review-dg.patch.gz

still unfinished review patch

[darijgr]

comment:8

OOPS wrong thread, sorry!

[tscrim]

comment:9

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[darijgr]

comment:11

1. Why does this depend on Implement Similarity Class Types #14907?

sage -t devel/sage-main/sage/combinat/ribbon_tableau.py
**********************************************************************
File "devel/sage-main/sage/combinat/ribbon_tableau.py", line 201, in sage.combinat.ribbon_tableau.RibbonTableaux
Failed example:
    for i in R: i.pp(); print
Expected:
      .  .  0  0  0
      .  0  0  2
      1  0  1
Got:
      .  .  0  0  0
      .  0  0  2
      1  0  1
    <BLANKLINE>
      .  .  1  0  0
      .  0  0  0
      1  0  2
    <BLANKLINE>
      .  .  0  0  0
      .  1  0  1
      2  0  0
    <BLANKLINE>
**********************************************************************

This seems to be a bug with the doctesting framework, which thinks of empty lines as EOM. Just replacing "print" by "print 'some_nonempty_string'" does the trick.

[tscrim]

comment:13

Fixed the above (all one has to do was add <BLANKLINE>) and added the comment that Arthur and I talked about via email.

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[tscrim]

Changed dependencies from #14772 #13589 #14907 to #7983 #14772 #13589 #14907

[tscrim]

comment:21

Try it with #7983. I'm not getting any fuzz (in the combinat queue).

[jeffpferreira]

comment:22

Travis,

Yes that worked. It now applies without any fuzz. Thanks.

Jeff

[tscrim]

comment:23

Thanks for catching that Jeff.

[jeffpferreira]

comment:24

I get a warning when building the doc:

[combinat ] /Applications/sage/local/lib/python2.7/site-packages/sage/combinat/ribbon_tableau.py:docstring of sage.combinat.ribbon_tableau.RibbonTableau:23: WARNING: Literal block expected; none found.

[tscrim]

comment:25

I've fixed the offending docstring.

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[jdemeyer]

Changed dependencies from #7983 #14772 #13589 #14907 to #7983, #14772, #13589, #14907, #10630

[tscrim]

Attachment: trac_14101-remove_cc_skew-ts.patch.gz

[tscrim]

comment:28

Trivial rebase over changes in sources.py in #14772.

[jdemeyer]

Merged: sage-5.12.beta4