Remove CombinatorialClass from Compositions

[tscrim]

Part of #12913.

Depends on #14065

CC: @sagetrac-sage-combinat @nthiery

Component: combinatorics

Keywords: deprecation

Author: Travis Scrimshaw

Reviewer: Vincent Delecroix

Merged: sage-5.8.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14063

[tscrim]

Dependencies: #14065

[tscrim]

Author: Travis Scrimshaw

[videlec]

comment:2

Hi,

• composition_from_subset must be renamed to from_subset
• You may remove the few trailing whitespaces that remain.

The rest looks good.

Vincent

[videlec]

comment:3

Comments on the doc in composition.py

• line 786: list(Compositions(4)) may be replaced with Compositions(4).list() (idem lines 877, 882, 927)
• line 844: there is a strange sharp at the end of the line
• line 859: a space is missing

[tscrim]

comment:4

Made fixes based on your comments.

Thanks,

Travis

[videlec]

comment:5

Great job !

Vincent

[jdemeyer]

Reviewer: Vincent Delecroix

[jdemeyer]

comment:7

How was this patch file created, as some headers are missing? You should use hg export [tip].

[tscrim]

comment:8

Forgot to export, sorry about that. Fixed.

[jdemeyer]

Merged: sage-5.8.beta1

[jdemeyer]

comment:10

The LaTeX documentation doesn't build because you use backslashes inside the

def cardinality(self):
"""
"""

docstring instead of

def cardinality(self):
r"""
"""

[jdemeyer]

Changed merged from sage-5.8.beta1 to none

[tscrim]

comment:11

Made the fixes (I put it in a few other places as well). I'll double/triple-check over the compiled docbuild once it finishes the rebuild.

[tscrim]

comment:12

I also fixed a broken link. Jeroen, would it be okay if I set this back to positive review?

Sorry about this,

Travis

[tscrim]

Fixed docstrings

[tscrim]

comment:13

Attachment: trac_14063-remove_cc_compositions-ts.patch.gz

I'm setting this back to positive review...I hope that's okay...

[jdemeyer]

Merged: sage-5.8.beta2