-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Affine and Euclidean groups #14015
Comments
Initial patch |
This comment has been minimized.
This comment has been minimized.
comment:1
Attachment: trac_14015_affine_group.patch.gz |
Attachment: trac_14015-affine_groups-ts.patch.gz |
comment:3
Hey Volker, Here's a rebased version with my review changes. I've removed the need for the Best, Travis For patchbot: Apply: trac_14015-affine_groups-ts.patch |
Reviewer: Travis Scrimshaw |
This comment has been minimized.
This comment has been minimized.
comment:4
The |
comment:5
You can have the GAP's affine groups and have the If the input format needs to be changed and exposed to the global namespace, you can implement a |
comment:6
And you need some way to circumvent the enforced argument normalization for internal use where you know that the arguments don't have to be normalized. In terms of complexity / lines of code, I think its pretty much a draw. Which is to say, you end up using a lot of complicated machinery for no real advantage. And it gets even more complicated if you start deriving the class. And it breaks the symmetry between different implementations. If I had seen a real advantage with the |
Changed author from Volker Braun to Volker Braun, Travis Scrimshaw |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Volker Braun |
Merged: sage-5.11.beta1 |
This ticket implements basic affine groups and Euclidean groups:
Apply:
Depends on #14040
Depends on #14014
Component: group theory
Author: Volker Braun, Travis Scrimshaw
Reviewer: Travis Scrimshaw, Volker Braun
Merged: sage-5.11.beta1
Issue created by migration from https://trac.sagemath.org/ticket/14015
The text was updated successfully, but these errors were encountered: